From 4ac21574532151341b9f7ea44bd0c3a4f41018ac Mon Sep 17 00:00:00 2001 From: moodler Date: Tue, 19 Oct 2004 09:19:48 +0000 Subject: [PATCH] Changes for XHTML and accessibility compliance --- mod/assignment/lib.php | 30 +++++++++++++------------ mod/assignment/mod.html | 40 +++++++++++++++++----------------- mod/assignment/submissions.php | 13 +++++------ mod/assignment/view.php | 6 ++--- 4 files changed, 44 insertions(+), 45 deletions(-) diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php index f7011a525e..2a45366233 100644 --- a/mod/assignment/lib.php +++ b/mod/assignment/lib.php @@ -544,27 +544,28 @@ function assignment_print_difference($time) { function assignment_print_submission($assignment, $user, $submission, $teachers, $grades) { global $THEME, $USER; - echo "\n"; + echo "\n
"; echo "\n"; if ($assignment->type == OFFLINE) { - echo "\n"; - echo "\n"; echo ""; if ($assignment->type != OFFLINE) { - echo "\n"; - echo "\n"; if ($submission->timemodified > $submission->timemarked) { echo ""; @@ -607,20 +609,20 @@ function assignment_print_feedback($course, $submission, $assignment) { error("Weird assignment error"); } - echo "\n
body\" WIDTH=35 VALIGN=TOP>"; + echo "\nbody\" width=\"35\" valign=\"top\">"; } else { - echo "\nbody\" WIDTH=35 VALIGN=TOP>"; + echo "\nbody\" width=\"35\" valign\"top\">"; } print_user_picture($user->id, $assignment->course, $user->picture); echo "cellheading\">".fullname($user, true); + echo "cellheading\">".fullname($user, true); if ($assignment->type != OFFLINE and $submission->timemodified) { echo "  ".get_string("lastmodified").": "; echo userdate($submission->timemodified); echo assignment_print_difference($assignment->timedue - $submission->timemodified); echo ""; } + echo "
cellcontent\">"; + echo "\n
cellcontent\">"; if ($submission->timemodified) { assignment_print_user_files($assignment, $user); } else { @@ -574,11 +575,12 @@ function assignment_print_submission($assignment, $user, $submission, $teachers, } echo "\n
"; + echo ""; if (!$submission->teacher) { $submission->teacher = $USER->id; } print_user_picture($submission->teacher, $assignment->course, $teachers[$submission->teacher]->picture); + echo "cellheading2\">"; } else { @@ -592,7 +594,7 @@ function assignment_print_submission($assignment, $user, $submission, $teachers, if ($submission->timemarked) { echo "  ".userdate($submission->timemarked).""; } - echo "

"; echo "
"; - echo "\n"; + echo "\n
"; + echo "\n"; echo "\n"; - echo "\n"; - echo ""; - echo "\n
body\" width=35 valign=TOP>"; + echo "\nbody\" width=\"35\" valign=\"top\">"; print_user_picture($teacher->id, $course->id, $teacher->picture); echo "cellheading\">".fullname($teacher); - echo "  ".userdate($submission->timemarked).""; + echo "cellheading\">".fullname($teacher); + echo "  ".userdate($submission->timemarked).""; echo "
cellcontent\">"; + echo "\n
cellcontent\">"; - echo "

"; + echo "

"; if ($assignment->grade) { if ($submission->grade or $submission->timemarked) { echo get_string("grade").": $submission->grade"; diff --git a/mod/assignment/mod.html b/mod/assignment/mod.html index 27157086e4..b4886b36cf 100644 --- a/mod/assignment/mod.html +++ b/mod/assignment/mod.html @@ -28,13 +28,13 @@

- + - - + - + - - + + - - + + - - + +

:

: - + " />

:

+ 		:

:

: dirroot/mod/assignment/lib.php"); @@ -82,7 +82,7 @@

:

:

:

: id, "grade", "$form->grade"); ?>

:

: maxbytes, $course->maxbytes); choose_from_menu ($choices, "maxbytes", $form->maxbytes, ""); ?>

:

: timedue); echo " - "; @@ -118,14 +118,14 @@

- - - - - - - -" /> -" /> + + + + + + + +" /> +" />
diff --git a/mod/assignment/submissions.php b/mod/assignment/submissions.php index 8a7251edab..b80603b1dc 100644 --- a/mod/assignment/submissions.php +++ b/mod/assignment/submissions.php @@ -168,10 +168,10 @@ if ($allowedtograde) { echo '
'; echo "
"; - echo ""; - echo ""; - echo "id\" />"; - echo ""; + echo ""; + echo ""; + echo "id\" />"; + echo ""; echo "
"; } @@ -186,10 +186,7 @@ if ($allowedtograde) { echo "
"; - echo ""; - echo ""; - echo "id\" />"; - echo ""; + echo ""; echo "
"; echo "
"; } diff --git a/mod/assignment/view.php b/mod/assignment/view.php index b81625d7a8..af0e4cfd8c 100644 --- a/mod/assignment/view.php +++ b/mod/assignment/view.php @@ -39,7 +39,7 @@ $strassignment = get_string("modulename", "assignment"); print_header_simple($assignment->name, "", - "id>$strassignments -> $assignment->name", + "id\">$strassignments -> $assignment->name", "", "", true, update_module_button($cm->id, $course->id, $strassignment), navmenu($course, $cm)); if (isteacher($course->id)) { @@ -64,8 +64,8 @@ notice(get_string("activityiscurrentlyhidden")); } - print_simple_box_start("CENTER"); - print_heading($assignment->name, "CENTER"); + print_simple_box_start("center"); + print_heading($assignment->name, "center"); $timedifference = $assignment->timedue - time(); if ($timedifference < 31536000) { // Don't bother showing dates over a year in the future -- 2.39.5