From 4b3b9625145977cb36cb30ffb54f549747505f66 Mon Sep 17 00:00:00 2001
From: nicolasconnault <nicolasconnault>
Date: Mon, 26 Mar 2007 08:00:21 +0000
Subject: [PATCH] MDL-9038: Groups can now be created outside of any groupings.
 The number of groups within [Not in a grouping] is also correct now.

---
 group/group.php | 16 ++++++++++++++--
 group/index.php |  3 +++
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/group/group.php b/group/group.php
index 060f70a031..260a3578e7 100644
--- a/group/group.php
+++ b/group/group.php
@@ -68,17 +68,29 @@ if ($success) {
         }
         elseif (isset($frm->update)) {
             if (! $groupid) { //OK, new group.
+                // Allow groups to be created outside of groupings
+                /*
                 if (GROUP_NOT_IN_GROUPING == $groupingid) {
                     print_error('errornotingrouping', 'group', groups_home_url($courseid), get_string('notingrouping', 'group'));
                 }
+                */
                 $success = (bool)$groupid = groups_create_group($courseid); //$groupsettings);
-                $success = groups_add_group_to_grouping($groupid, $groupingid);
+                
+                if ($groupingid != GROUP_NOT_IN_GROUPING) {
+                    $success = groups_add_group_to_grouping($groupid, $groupingid);
+                }
             }
             elseif ($groupingid != $newgrouping) { //OK, move group.
+                // Allow groups to be created outside of groupings
+                /*
                 if (GROUP_NOT_IN_GROUPING == $newgrouping) {
                     print_error('errornotingrouping', 'group', groups_home_url($courseid), get_string('notingrouping', 'group'));
                 }
-                $success = $success && groups_remove_group_from_grouping($groupid, $groupingid);
+                */
+                if ($groupingid != GROUP_NOT_IN_GROUPING) {
+                    $success = $success && groups_remove_group_from_grouping($groupid, $groupingid);
+                }
+
                 $success = $success && groups_add_group_to_grouping($groupid, $newgrouping);
             }
             if ($success) {
diff --git a/group/index.php b/group/index.php
index c47c597a36..b9b416bcfd 100644
--- a/group/index.php
+++ b/group/index.php
@@ -115,9 +115,12 @@ if ($success) {
         case 'removegroup':
             break;
         case 'showcreategroupform':
+            // Allow groups to be created outside of groupings
+            /*
             if (GROUP_NOT_IN_GROUPING == $groupingid) {
                 print_error('errornotingrouping', 'group', groups_home_url($courseid), get_string('notingrouping', 'group'));
             }
+            */
             redirect(groups_group_edit_url($courseid, null, $groupingid, false));
             break;
         case 'addgroupstogroupingform':
-- 
2.39.5