From 4f16959f58e002ec87758845e82c0f3ec8c39d4c Mon Sep 17 00:00:00 2001 From: David Mudrak Date: Mon, 4 Jan 2010 18:23:32 +0000 Subject: [PATCH] MDL-20058 workshop grades can be overridden in grading evaluation phase only --- mod/workshop/assessment.php | 2 +- mod/workshop/submission.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/workshop/assessment.php b/mod/workshop/assessment.php index 9c87490585..39c4e09abd 100644 --- a/mod/workshop/assessment.php +++ b/mod/workshop/assessment.php @@ -58,7 +58,7 @@ $currenttab = 'assessment'; $canviewallassessments = has_capability('mod/workshop:viewallassessments', $workshop->context); $canviewallsubmissions = has_capability('mod/workshop:viewallsubmissions', $workshop->context); -$canoverridegrades = has_capability('mod/workshop:overridegrades', $workshop->context); +$canoverridegrades = ($workshop->phase == workshop::PHASE_EVALUATION) and has_capability('mod/workshop:overridegrades', $workshop->context); $isreviewer = ($USER->id == $assessment->reviewerid); $isauthor = ($USER->id == $submission->authorid); diff --git a/mod/workshop/submission.php b/mod/workshop/submission.php index d1449bff25..e04150ce04 100644 --- a/mod/workshop/submission.php +++ b/mod/workshop/submission.php @@ -57,7 +57,7 @@ if ($id) { // submission is specified $ownsubmission = $submission->authorid == $USER->id; $canviewall = has_capability('mod/workshop:viewallsubmissions', $workshop->context); $cansubmit = has_capability('mod/workshop:submit', $workshop->context); -$canoverride = has_capability('mod/workshop:overridegrades', $workshop->context); +$canoverride = ($workshop->phase == workshop::PHASE_EVALUATION) and has_capability('mod/workshop:overridegrades', $workshop->context); $isreviewer = $DB->record_exists('workshop_assessments', array('submissionid' => $submission->id, 'reviewerid' => $USER->id)); if ($submission->id and ($ownsubmission or $canviewall or $isreviewer)) { -- 2.39.5