From 5ca18631bc8bdba47fad5d87ef115a7c757052ff Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Tue, 2 Sep 2008 06:03:37 +0000
Subject: [PATCH] MDL-16029 removing recently added support for $extralocation
 from print_error(), thanks TIm for pointing out this is not the recommended
 way anymore

---
 lib/deprecatedlib.php |  2 +-
 lib/setuplib.php      | 27 ++++++++++-----------------
 lib/weblib.php        | 19 +++++++++----------
 3 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/lib/deprecatedlib.php b/lib/deprecatedlib.php
index c6db193133..a0d3062ab9 100644
--- a/lib/deprecatedlib.php
+++ b/lib/deprecatedlib.php
@@ -573,7 +573,7 @@ function error($message, $link='') {
         throw new moodle_exception('notlocalisederrormessage', 'error', $link, $message);
     }
 
-    _print_normal_error('notlocalisederrormessage', 'error', $message, $link, debug_backtrace(), null, null, true); // show debug warning
+    _print_normal_error('notlocalisederrormessage', 'error', $message, $link, debug_backtrace(), null, true); // show debug warning
 }
 
 
diff --git a/lib/setuplib.php b/lib/setuplib.php
index 289b558944..73bb67abcd 100644
--- a/lib/setuplib.php
+++ b/lib/setuplib.php
@@ -18,7 +18,6 @@ class moodle_exception extends Exception {
     public $a;
     public $link;
     public $debuginfo;
-    public $extralocations;
 
     /**
      * Constructor
@@ -27,25 +26,19 @@ class moodle_exception extends Exception {
      * @param string $link The url where the user will be prompted to continue. If no url is provided the user will be directed to the site index page.
      * @param object $a Extra words and phrases that might be required in the error string
      * @param string $debuginfo optional debugging information
-     * @param array $extralocations An array of strings with other locations to look for string files
      */
-    function __construct($errorcode, $module='error', $link='', $a=NULL, $debuginfo=null, $extralocations=null) {
-        if (empty($module) || $module === 'moodle' || $module === 'core') {
+    function __construct($errorcode, $module='', $link='', $a=NULL, $debuginfo=null) {
+        if (empty($module) || $module == 'moodle' || $module == 'core') {
             $module = 'error';
         }
 
-        $this->errorcode      = $errorcode;
-        $this->module         = $module;
-        $this->link           = $link;
-        $this->a              = $a;
-        $this->debuginfo      = $debuginfo;
-        $this->extralocations = $extralocations;
-
-        $message = get_string($errorcode, $module, $a, $extralocations);
-        if ($module === 'error' and strpos($message, '[[') === 0) {
-            //search in moodle file if error specified - needed for backwards compatibility
-            $message = get_string($errorcode, 'moodle', $a, $extralocations);
-        }
+        $this->errorcode = $errorcode;
+        $this->module    = $module;
+        $this->link      = $link;
+        $this->a         = $a;
+        $this->debuginfo = $debuginfo;
+
+        $message = get_string($errorcode, $module, $a);
 
         parent::__construct($message, 0);
     }
@@ -60,7 +53,7 @@ function default_exception_handler($ex) {
     array_unshift($backtrace, $place);
 
     if ($ex instanceof moodle_exception) {
-        _print_normal_error($ex->errorcode, $ex->module, $ex->a, $ex->link, $backtrace, $ex->debuginfo, $ex->extralocations);
+        _print_normal_error($ex->errorcode, $ex->module, $ex->a, $ex->link, $backtrace, $ex->debuginfo);
     } else {
         _print_normal_error('generalexceptionmessage', 'error', $ex->getMessage(), '', $backtrace);
     }
diff --git a/lib/weblib.php b/lib/weblib.php
index 97b62182b9..0f6ca41bdd 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -5546,10 +5546,9 @@ function print_scale_menu_helpbutton($courseid, $scale, $return=false) {
  * @param string $module name of module
  * @param string $link The url where the user will be prompted to continue. If no url is provided the user will be directed to the site index page.
  * @param object $a Extra words and phrases that might be required in the error string
- * @param array $extralocations An array of strings with other locations to look for string files
  * @return terminates script, does not return!
  */
-function print_error($errorcode, $module='error', $link='', $a=NULL, $extralocations=NULL) {
+function print_error($errorcode, $module='error', $link='', $a=NULL) {
     global $CFG, $UNITTEST;
 
     // If unittest running, throw exception instead
@@ -5565,16 +5564,16 @@ function print_error($errorcode, $module='error', $link='', $a=NULL, $extralocat
 
     if (!isset($CFG->theme) or !isset($CFG->stylesheets)) {
         // error found before setup.php finished
-        _print_early_error($errorcode, $module, $a, $extralocations);
+        _print_early_error($errorcode, $module, $a);
     } else {
-        _print_normal_error($errorcode, $module, $a, $link, debug_backtrace(), null, $extralocations);
+        _print_normal_error($errorcode, $module, $a, $link, debug_backtrace());
     }
 }
 
 /**
  * Internal function - do not use directly!!
  */
-function _print_normal_error($errorcode, $module, $a, $link, $backtrace, $debuginfo=null, $extralocations=null, $showerrordebugwarning=false) {
+function _print_normal_error($errorcode, $module, $a, $link, $backtrace, $debuginfo=null, $showerrordebugwarning=false) {
     global $CFG, $SESSION, $THEME, $DB;
 
     if ($DB) {
@@ -5588,10 +5587,10 @@ function _print_normal_error($errorcode, $module, $a, $link, $backtrace, $debugi
         $modulelink = $module;
     }
 
-    $message = get_string($errorcode, $module, $a, $extralocations);
+    $message = get_string($errorcode, $module, $a);
     if ($module === 'error' and strpos($message, '[[') === 0) {
         //search in moodle file if error specified - needed for backwards compatibility
-        $message = get_string($errorcode, 'moodle', $a, $extralocations);
+        $message = get_string($errorcode, 'moodle', $a);
     }
 
     if (defined('FULLME') && FULLME == 'cron') {
@@ -5668,11 +5667,11 @@ function _print_normal_error($errorcode, $module, $a, $link, $backtrace, $debugi
  * Internal function - do not use directly!!
  * This function is used if fatal error occures before the themes are fully initialised (eg. in lib/setup.php)
  */
-function _print_early_error($errorcode, $module, $a, $extralocations=NULL) {
-    $message = get_string($errorcode, $module, $a, $extralocations);
+function _print_early_error($errorcode, $module, $a) {
+    $message = get_string($errorcode, $module, $a);
     if ($module === 'error' and strpos($message, '[[') === 0) {
         //search in moodle file if error specified - needed for backwards compatibility
-        $message = get_string($errorcode, 'moodle', $a, $extralocations);
+        $message = get_string($errorcode, 'moodle', $a);
     }
     $message = clean_text($message);
 
-- 
2.39.5