From 5d00b3ad99d0b75bef69de42730c469f8f1e3aac Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Sun, 23 Apr 2006 20:33:01 +0000
Subject: [PATCH] page parameter cleanup

---
 mod/assignment/submissions.php | 6 +++---
 mod/assignment/upload.php      | 4 ++--
 mod/assignment/view.php        | 5 ++---
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/mod/assignment/submissions.php b/mod/assignment/submissions.php
index 5e3c40abd4..6b5693d98b 100644
--- a/mod/assignment/submissions.php
+++ b/mod/assignment/submissions.php
@@ -3,9 +3,9 @@
     require_once("../../config.php");
     require_once("lib.php");
 
-    $id      = optional_param('id');            // Course module ID
-    $a       = optional_param('a');             // Assignment ID
-    $mode    = optional_param('mode', 'all');   // What mode are we in?
+    $id   = optional_param('id', 0, PARAM_INT);          // Course module ID
+    $a    = optional_param('a', 0, PARAM_INT);           // Assignment ID
+    $mode = optional_param('mode', 'all', PARAM_ALPHA);  // What mode are we in?
 
     if ($id) {
         if (! $cm = get_record("course_modules", "id", $id)) {
diff --git a/mod/assignment/upload.php b/mod/assignment/upload.php
index 231048d5dc..cfb862753b 100644
--- a/mod/assignment/upload.php
+++ b/mod/assignment/upload.php
@@ -3,8 +3,8 @@
     require_once("../../config.php");
     require_once("lib.php");
 
-    $id      = optional_param('id');            // Course module ID
-    $a       = optional_param('a');             // Assignment ID
+    $id = optional_param('id', 0, PARAM_INT);  // Course module ID
+    $a  = optional_param('a', 0, PARAM_INT);   // Assignment ID
 
     if ($id) {
         if (! $cm = get_record("course_modules", "id", $id)) {
diff --git a/mod/assignment/view.php b/mod/assignment/view.php
index 437922c0a3..a773b77353 100644
--- a/mod/assignment/view.php
+++ b/mod/assignment/view.php
@@ -3,9 +3,8 @@
     require_once("../../config.php");
     require_once("lib.php");
  
-    $id = optional_param('id');    // Course Module ID
-    $a  = optional_param('a');
-
+    $id = optional_param('id', 0, PARAM_INT);  // Course Module ID
+    $a  = optional_param('a', 0, PARAM_INT);   // Assignment ID
 
     if ($id) {
         if (! $cm = get_record("course_modules", "id", $id)) {
-- 
2.39.5