From 5e87b920e3f740c5b0e686e9bb83e1512585024f Mon Sep 17 00:00:00 2001
From: moodler <moodler>
Date: Fri, 22 Dec 2006 04:52:13 +0000
Subject: [PATCH] Added CDATA to Javascript

---
 lib/formslib.php    | 2 ++
 lib/weblib.php      | 4 +++-
 mod/hotpot/view.php | 6 +++---
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/formslib.php b/lib/formslib.php
index 146248704c..88c0f51b9a 100644
--- a/lib/formslib.php
+++ b/lib/formslib.php
@@ -1045,6 +1045,7 @@ function validate_' . $this->_attributes['id'] . '(frm) {
 
     function getLockOptionEndScript(){
         $js = '<script type="text/javascript" language="javascript">'."\n";
+        $js .= '//<![CDATA['."\n";
         $js .= "var ".$this->getAttribute('id')."items= {";
         foreach ($this->_dependencies as $dependentOn => $elements){
             $js .= "'$dependentOn'".' : {dependents :[';
@@ -1065,6 +1066,7 @@ function validate_' . $this->_attributes['id'] . '(frm) {
         $js=rtrim($js, ",\n");
         $js .= '};'."\n";
         $js .="lockoptionsallsetup('".$this->getAttribute('id')."');\n";
+        $js .='//]]>'."\n";
         $js .='</script>'."\n";
         return $js;
     }
diff --git a/lib/weblib.php b/lib/weblib.php
index 8e5e26a69a..fe19c4b7fe 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -3694,7 +3694,8 @@ function use_html_editor($name='', $editorhidebuttons='', $id='') {
     if ($id === '') {
         $id = 'edit-'.$name;
     }
-    echo '<script language="javascript" type="text/javascript" defer="defer">'."\n";
+    echo "\n".'<script language="javascript" type="text/javascript" defer="defer">'."\n";
+    echo '//<![CDATA['."\n";
     echo "$editor = new HTMLArea('$id');\n";
     echo "var config = $editor.config;\n";
 
@@ -3705,6 +3706,7 @@ function use_html_editor($name='', $editorhidebuttons='', $id='') {
     } else {
         echo "\n$editor.generate();\n";
     }
+    echo '//]]>'."\n";
     echo '</script>'."\n";
 }
 
diff --git a/mod/hotpot/view.php b/mod/hotpot/view.php
index e6e6c71976..905f1b755b 100644
--- a/mod/hotpot/view.php
+++ b/mod/hotpot/view.php
@@ -255,7 +255,7 @@
         foreach ($feedback as $i=>$str) {
             $js .= 'FEEDBACK['.$i."] = $str;\n";
         }
-        $js = '<script type="text/javascript" language="javascript">'."<!--\n"."FEEDBACK = new Array();\n".$js."//--></script>\n";
+        $js = '<script type="text/javascript" language="javascript">'."\n//<![CDATA[\n"."FEEDBACK = new Array();\n".$js."//]]>\n</script>\n";
         $hp->html = preg_replace('|</head>|i', "$js</head>", $hp->html, 1);
     }
     // insert hot-potatoes.js
@@ -302,7 +302,7 @@
         //  so some old or modified themes may not insert $body_tags
         $body .= ""
         .   '<script type="text/javascript">'."\n"
-        .   "<!--\n"
+        .   "//<![CDATA[\n"
         .   "   var s = (typeof(window.onload)=='function') ? onload.toString() : '';\n"
         .   "   if (s.indexOf('".$matches[3]."')<0) {\n"
         .   "       if (s=='') {\n" // no previous onload
@@ -312,7 +312,7 @@
         .   "           window.onload = new Function('window.onload_hotpot();'+'".$matches[3]."');\n"
         .   "       }\n"
         .   "    }\n"
-        .   "//-->\n"
+        .   "//]]>\n"
         .   "</script>\n"
         ;
         $footer = '</body>'.$footer;
-- 
2.39.5