From 5ebce7bb5c3a2ddc4e40c1f8d8299177cda198b3 Mon Sep 17 00:00:00 2001
From: nicolasconnault <nicolasconnault>
Date: Wed, 19 Mar 2008 16:11:37 +0000
Subject: [PATCH] MDL-13880 Overridden and excluded grades are now coloured
 with alternate row colours that override the default alternate row colours
 (gray). I also fixed the long-standing notice about aggregationposition. See
 attached patch.

---
 grade/report/grader/lib.php              |  6 +++++-
 grade/report/grader/preferences_form.php |  4 +++-
 grade/report/grader/styles.php           | 18 +++++++++++++++++-
 3 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/grade/report/grader/lib.php b/grade/report/grader/lib.php
index 0625854449..799d12d47b 100644
--- a/grade/report/grader/lib.php
+++ b/grade/report/grader/lib.php
@@ -749,11 +749,15 @@ class grade_report_grader extends grade_report {
                 if ($grade->is_overridden()) {
                     $cellclasses .= ' overridden';
                 }
+                
+                if ($grade->is_excluded()) {
+                    $cellclasses .= ' excluded';
+                }
 
                 $studentshtml .= '<td class="'.$cellclasses.'">';
 
                 if ($grade->is_excluded()) {
-                    $studentshtml .= get_string('excluded', 'grades'); // TODO: improve visual representation of excluded grades
+                    $studentshtml .= get_string('excluded', 'grades') . ' ';
                 }
 
                 // Do not show any icons if no grade (no record in DB to match)
diff --git a/grade/report/grader/preferences_form.php b/grade/report/grader/preferences_form.php
index 9c1e7c94c6..3033f23e1c 100644
--- a/grade/report/grader/preferences_form.php
+++ b/grade/report/grader/preferences_form.php
@@ -153,7 +153,9 @@ class grader_report_preferences_form extends moodleform {
                     $type = 'select';
                     // MDL-11478
                     // get default aggregationposition from grade_settings
-                    $course_value = grade_get_setting($course->id, $pref, $CFG->{$full_pref});
+                    if (!empty($CFG->{$full_pref})) {
+                        $course_value = grade_get_setting($course->id, $pref, $CFG->{$full_pref});
+                    }
                     
                     if ($pref == 'aggregationposition') {
                         if (!empty($options[$course_value])) {
diff --git a/grade/report/grader/styles.php b/grade/report/grader/styles.php
index 956bd3f9fc..14ab278fef 100644
--- a/grade/report/grader/styles.php
+++ b/grade/report/grader/styles.php
@@ -21,7 +21,7 @@
 }
 
 .grade-report-grader table#user-grades td.overridden {
-  background-color: #dddddd;
+  background-color: #EFD9B3;
 }
 
 .grade-report-grader table#user-grades tr.avg td.cell {
@@ -32,6 +32,22 @@
     background-color: #efefef;
 }
 
+.grade-report-grader table#user-grades tr.even td.overridden {
+  background-color: #F3E4C0; 
+}
+
+.grade-report-grader table#user-grades tr.odd td.overridden {
+  background-color: #EFD9A4;
+}
+
+.grade-report-grader table#user-grades tr.even td.excluded {
+  background-color: #EABFFF; 
+}
+
+.grade-report-grader table#user-grades tr.odd td.excluded {
+  background-color: #E5AFFF;
+}
+
 .grade-report-grader table#user-grades tr.odd th.header { 
     background-color: #efefef;
     background-image: none;
-- 
2.39.5