From 61867c8382bdcdd2fda5824d3cbee7493f8b6ab6 Mon Sep 17 00:00:00 2001 From: nicolasconnault Date: Thu, 20 Aug 2009 13:14:52 +0000 Subject: [PATCH] MDL-19794 Upgraded calls to link_to_popup_window() --- course/category.php | 7 ++++--- course/lib.php | 19 +++++++++++++------ course/report/log/indexlive.php | 8 +++++--- course/report/log/mod.php | 4 +++- 4 files changed, 25 insertions(+), 13 deletions(-) diff --git a/course/category.php b/course/category.php index 2a6aa8a5c9..79fb74b56c 100644 --- a/course/category.php +++ b/course/category.php @@ -395,9 +395,10 @@ $OUTPUT->old_icon_url('i/key') . '" alt="'.$strrequireskey.'" />'; } if (!empty($acourse->summary)) { - link_to_popup_window ("/course/info.php?id=$acourse->id", "courseinfo", - ''.get_string('info').'', - 400, 500, $strsummary); + $link = html_link::make("/course/info.php?id=$acourse->id", ''.get_string('info').''); + $link->add_action(new popup_action('click', $link->url, 'courseinfo')); + $link->title = $strsummary; + echo $OUTPUT->link($link); } echo ""; } diff --git a/course/lib.php b/course/lib.php index f6370139ae..1bc39ece56 100644 --- a/course/lib.php +++ b/course/lib.php @@ -365,7 +365,9 @@ function print_log($course, $user=0, $date=0, $order="l.time ASC", $page=0, $per echo "".userdate($log->time, '%a'). ' '.userdate($log->time, $strftimedatetime)."\n"; echo "\n"; - link_to_popup_window("/iplookup/index.php?ip=$log->ip&user=$log->userid", 'iplookup',$log->ip, 440, 700); + $link = html_link::make("/iplookup/index.php?ip=$log->ip&user=$log->userid", $log->ip); + $link->add_action(new popup_action('click', $link->url, 'iplookup', array('height' => 440, 'width' => 700))); + echo $OUTPUT->link($link); echo "\n"; $fullname = fullname($log, has_capability('moodle/site:viewfullnames', get_context_instance(CONTEXT_COURSE, $course->id))); echo "\n"; @@ -376,7 +378,9 @@ function print_log($course, $user=0, $date=0, $order="l.time ASC", $page=0, $per if($brokenurl) { echo $displayaction; } else { - link_to_popup_window( make_log_url($log->module,$log->url), 'fromloglive',$displayaction, 440, 700); + $link = html_link::make(make_log_url($log->module,$log->url), $displayaction); + $link->add_action(new popup_action('click', $link->url, 'fromloglive'), array('height' => 440, 'width' => 700)); + echo $OUTPUT->link($link); } echo "\n";; echo "{$log->info}\n"; @@ -473,7 +477,9 @@ function print_mnet_log($hostid, $course, $user=0, $date=0, $order="l.time ASC", echo "".userdate($log->time, '%a'). ' '.userdate($log->time, $strftimedatetime)."\n"; echo "\n"; - link_to_popup_window("/iplookup/index.php?ip=$log->ip&user=$log->userid", 'iplookup',$log->ip, 400, 700); + $link = html_link::make("/iplookup/index.php?ip=$log->ip&user=$log->userid", $log->ip); + $link->add_action(new popup_action('click', $link->url, 'iplookup', array('height' => 400, 'width' => 700))); + echo $OUTPUT->link($link); echo "\n"; $fullname = fullname($log, has_capability('moodle/site:viewfullnames', get_context_instance(CONTEXT_COURSE, $course->id))); echo "\n"; @@ -1962,9 +1968,10 @@ function print_category_info($category, $depth, $showcourses = false) { echo ''; } if ($course->summary) { - link_to_popup_window ('/course/info.php?id='.$course->id, 'courseinfo', - ''.$strsummary.'', - 400, 500, $strsummary); + $link = html_link::make('/course/info.php?id='.$course->id, ''.$strsummary.''); + $link->add_action(new popup_action('click', $link->url, 'courseinfo', array('height' => 400, 'width' => 500))); + $link->title = $strsummary; + echo $OUTPUT->link($link); } else { echo ''; } diff --git a/course/report/log/indexlive.php b/course/report/log/indexlive.php index 43a557023a..30d07175b9 100644 --- a/course/report/log/indexlive.php +++ b/course/report/log/indexlive.php @@ -34,9 +34,11 @@ echo $OUTPUT->heading(get_string('loglive', 'coursereport_log')); - echo '
'; - link_to_popup_window('/course/report/log/live.php?id='. $course->id,'livelog', get_string('livelogs'), 500, 800); - echo '
'; + echo $OUTPUT->container_start('info'); + $link = html_link::make('/course/report/log/live.php?id='. $course->id, get_string('livelogs')); + $link->add_action(new popup_action('click', $link->url, 'livelog', array('height' => 500, 'width' => 800))); + echo $OUTPUT->link($link); + echo $OUTPUT->container_end(); echo $OUTPUT->footer(); diff --git a/course/report/log/mod.php b/course/report/log/mod.php index 84177a421c..f949ace821 100644 --- a/course/report/log/mod.php +++ b/course/report/log/mod.php @@ -16,7 +16,9 @@ if (has_capability('coursereport/log:viewlive', $context)) { echo $OUTPUT->heading(get_string('chooselivelogs') .':'); echo '

'; - link_to_popup_window('/course/report/log/live.php?id='. $course->id,'livelog', get_string('livelogs'), 500, 800); + $link = html_link::make('/course/report/log/live.php?id='. $course->id, get_string('livelogs')); + $link->add_action(new popup_action('click', $link->url, 'livelog', array('height' => 500, 'width' => 800))); + echo $OUTPUT->link($link); echo '

'; } ?> -- 2.39.5