From 621dca51f8b10959fc041d77a7efeb62bc547012 Mon Sep 17 00:00:00 2001 From: dongsheng Date: Thu, 14 Aug 2008 06:48:58 +0000 Subject: [PATCH] MDL-13766, test api_key, and remove shared secret in flickr plug-in --- repository/boxnet/repository.class.php | 3 +++ repository/flickr/repository.class.php | 6 ++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/repository/boxnet/repository.class.php b/repository/boxnet/repository.class.php index 1f9f2e858f..ebbd2fc4f7 100755 --- a/repository/boxnet/repository.class.php +++ b/repository/boxnet/repository.class.php @@ -21,6 +21,9 @@ class repository_boxnet extends repository{ $reset = optional_param('reset', 0, PARAM_INT); parent::__construct($repositoryid, $context, $options); $this->api_key = $this->get_option('api_key'); + if (empty($this->api_key)) { + throw new repository_exception('invalidapikey', 'repository_boxnet'); + } $sess_name = 'box_token'.$this->id; // reset session if(!empty($reset)) { diff --git a/repository/flickr/repository.class.php b/repository/flickr/repository.class.php index ce9ea6d95f..7bf2e699fc 100755 --- a/repository/flickr/repository.class.php +++ b/repository/flickr/repository.class.php @@ -17,10 +17,12 @@ class repository_flickr extends repository{ public function __construct($repositoryid, $context = SITEID, $options = array()){ global $SESSION, $action, $CFG; $options['page'] = optional_param('p', 1, PARAM_INT); - $options['secret'] = '7cb2f9d7cf70aebe'; parent::__construct($repositoryid, $context, $options); $this->api_key = $this->get_option('api_key'); - $this->flickr = new phpFlickr($this->api_key, $this->options['secret']); + if (empty($this->api_key)) { + throw new repository_exception('invalidapikey', 'repository_flickr'); + } + $this->flickr = new phpFlickr($this->api_key); $reset = optional_param('reset', 0, PARAM_INT); $sess_name = 'flickrmail'.$this->id; -- 2.39.5