From 62373088ddf448eaf306c2b9978e27d8f98f941f Mon Sep 17 00:00:00 2001 From: jamiesensei Date: Mon, 21 Jul 2008 14:40:26 +0000 Subject: [PATCH] MDL-15728 "quiz_report_load_questions should alias qqi.grade to maxgrade so that questions array has the required fields expected by much of the question code." --- mod/quiz/report/statistics/qstats.php | 10 +++++----- mod/quiz/report/statistics/statistics_table.php | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mod/quiz/report/statistics/qstats.php b/mod/quiz/report/statistics/qstats.php index 96e3d701d3..c546026974 100644 --- a/mod/quiz/report/statistics/qstats.php +++ b/mod/quiz/report/statistics/qstats.php @@ -122,8 +122,8 @@ class qstats{ $subquestionstats[$itemid] = $this->stats_init_object(); $subquestionstats[$itemid]->usedin = array(); $subquestionstats[$itemid]->differentweights = false; - $subquestionstats[$itemid]->grade = $this->questions[$state->question]->grade; - } else if ($subquestionstats[$itemid]->grade != $this->questions[$state->question]->grade){ + $subquestionstats[$itemid]->maxgrade = $this->questions[$state->question]->maxgrade; + } else if ($subquestionstats[$itemid]->maxgrade != $this->questions[$state->question]->maxgrade){ $subquestionstats[$itemid]->differentweights = true; } $this->_initial_states_walker($state, $subquestionstats[$itemid], false); @@ -135,15 +135,15 @@ class qstats{ $this->subquestions = question_load_questions(array_keys($subquestionstats)); foreach (array_keys($this->subquestions) as $qid){ $this->subquestions[$qid]->_stats = $subquestionstats[$qid]; - $this->subquestions[$qid]->grade = $this->subquestions[$qid]->_stats->grade; + $this->subquestions[$qid]->maxgrade = $this->subquestions[$qid]->_stats->maxgrade; $this->subquestions[$qid]->subquestion = true; - $this->_initial_question_walker($this->subquestions[$qid]->_stats, $this->subquestions[$qid]->_stats->grade); + $this->_initial_question_walker($this->subquestions[$qid]->_stats, $this->subquestions[$qid]->_stats->maxgrade); if ($subquestionstats[$qid]->differentweights){ notify(get_string('erroritemappearsmorethanoncewithdifferentweight', 'quiz_statistics', $this->subquestions[$qid]->name)); } } foreach (array_keys($this->questions) as $qid){ - $this->_initial_question_walker($this->questions[$qid]->_stats, $this->questions[$qid]->grade); + $this->_initial_question_walker($this->questions[$qid]->_stats, $this->questions[$qid]->maxgrade); $this->questions[$qid]->subquestion = false; } //go through the records one more time diff --git a/mod/quiz/report/statistics/statistics_table.php b/mod/quiz/report/statistics/statistics_table.php index 580ce9e031..5393b9feb1 100644 --- a/mod/quiz/report/statistics/statistics_table.php +++ b/mod/quiz/report/statistics/statistics_table.php @@ -121,7 +121,7 @@ class quiz_report_statistics_table extends flexible_table { return $question->qtype; } function col_intended_weight($question){ - return quiz_report_scale_sumgrades_as_percentage($question->grade, $this->quiz); + return quiz_report_scale_sumgrades_as_percentage($question->maxgrade, $this->quiz); } function col_effective_weight($question){ if (!$question->subquestion){ @@ -154,7 +154,7 @@ class quiz_report_statistics_table extends flexible_table { } function col_sd($question){ - return number_format($question->_stats->sd*100 / $question->grade, 2).' %'; + return number_format($question->_stats->sd*100 / $question->maxgrade, 2).' %'; } function col_s($question){ if (isset($question->_stats->s)){ -- 2.39.5