From 6463e8a6b691850a23516c807efaf70f21265f96 Mon Sep 17 00:00:00 2001
From: gustav_delius <gustav_delius>
Date: Thu, 6 Apr 2006 20:35:49 +0000
Subject: [PATCH] Fixing a large number of tidy warnings

---
 question/type/essay/questiontype.php       | 10 +++++-----
 question/type/match/questiontype.php       |  1 -
 question/type/multianswer/questiontype.php |  3 ++-
 question/type/multichoice/display.html     |  6 ++++--
 question/type/question.html                |  4 +++-
 question/type/truefalse/display.html       |  4 +---
 6 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/question/type/essay/questiontype.php b/question/type/essay/questiontype.php
index cc8ad8a2c1..e362eee3c8 100644
--- a/question/type/essay/questiontype.php
+++ b/question/type/essay/questiontype.php
@@ -119,7 +119,7 @@ class question_essay_qtype extends default_questiontype {
 
         $inputname = $nameprefix;
         
-        echo "<p>$stranswer: ".
+        echo "<p>$stranswer: </p>".
             '<div style="padding-left: 30px;">';   
         if (empty($options->readonly)) {    
             // the student needs to type in their answer so print out a text editor
@@ -128,9 +128,9 @@ class question_essay_qtype extends default_questiontype {
         } else {
             // it is read only, so just format the students answer and output it
             echo format_text($value);
-            echo '<input type="hidden" name="'.$inputname.'" value="'.htmlSpecialChars($value).'">'; // need hidden one for grading
+            echo '<input type="hidden" name="'.$inputname.'" value="'.htmlSpecialChars($value).'" />'; // need hidden one for grading
         }    
-        echo '</div></p>';
+        echo '</div>';
                     
         if (isset($state->responses['response'])) {
             $value = $state->responses['response'];
@@ -162,14 +162,14 @@ class question_essay_qtype extends default_questiontype {
             choose_from_menu($gradeoptions, $nameprefix."fraction", $state->responses['fraction'],"");
         } else if (!empty($options->readonly)) {
             //read only so format the comment and print it out
-            echo "<p>$strcomment: ".
+            echo "<p>$strcomment: </p>".
                 '<div style="padding-left: 30px;">';
             if (empty($value)) {  // no comment yet
                 echo format_text(get_string('nocommentsyet', 'quiz'));
             } else {
                 echo format_text($value, '', $formatoptions, $cmoptions->course);    
             }
-            echo '</div></p>';
+            echo '</div>';
         }
 
         // feedback
diff --git a/question/type/match/questiontype.php b/question/type/match/questiontype.php
index 6538198e4e..35531ec3e4 100644
--- a/question/type/match/questiontype.php
+++ b/question/type/match/questiontype.php
@@ -237,7 +237,6 @@ class question_match_qtype extends default_questiontype {
         $image = get_question_image($question, $cmoptions->course);
 
         ///// Print the input controls //////
-        echo '<table border="0" cellpadding="10" align="right">';
         foreach ($subquestions as $key => $subquestion) {
 
             /// Subquestion text:
diff --git a/question/type/multianswer/questiontype.php b/question/type/multianswer/questiontype.php
index e8cee24a38..4adf038e39 100644
--- a/question/type/multianswer/questiontype.php
+++ b/question/type/multianswer/questiontype.php
@@ -194,6 +194,7 @@ class embedded_cloze_qtype extends default_questiontype {
     function print_question_formulation_and_controls(&$question, &$state, $cmoptions, $options) {
         global $QTYPES;
         $readonly = empty($options->readonly) ? '' : 'readonly="readonly"';
+        $disabled = empty($options->readonly) ? '' : 'disabled="disabled"';
         $formatoptions->noclean = true;
         $formatoptions->para = false;
         $nameprefix = $question->name_prefix;
@@ -318,7 +319,7 @@ class embedded_cloze_qtype extends default_questiontype {
                                 ? ' selected="selected" ' : '';
                         $outputoptions .= "<option value=\"$mcanswer->id\" $selected>$mcanswer->answer</option>";
                     }
-                   echo "<select $popup $readonly $style name=\"$inputname\">";
+                   echo "<select $popup $disabled $style name=\"$inputname\">";
                    echo $outputoptions;
                    echo '</select>';
                    break;
diff --git a/question/type/multichoice/display.html b/question/type/multichoice/display.html
index de4f8fcbb7..ef553d29f6 100644
--- a/question/type/multichoice/display.html
+++ b/question/type/multichoice/display.html
@@ -17,8 +17,10 @@
         <td class="c0 control">
           <?php echo $answer->control; ?>
         </td>
-        <td class="c1 text <?php echo $answer->class ?>"><label for="<?php echo $answer->id ?>">
-          <?php echo $answer->text; ?>
+        <td class="c1 text <?php echo $answer->class ?>">
+          <label for="<?php echo $answer->id ?>">
+            <?php echo $answer->text; ?>
+          </label>
         </td>
         <td class="c0 feedback">
           <?php echo $answer->feedback; ?>
diff --git a/question/type/question.html b/question/type/question.html
index f6ac34a2ab..0b9649f9bf 100644
--- a/question/type/question.html
+++ b/question/type/question.html
@@ -6,7 +6,9 @@
 <table id="q<?php echo $question->id; ?>" class="que <?php echo $question->qtype; ?>"><tr><td>
   <div class="info">
     <span class="no"><?php echo $number; ?></span>
-    <span class="edit"><?php echo $editlink; ?></span>
+    <?php if ($editlink) { ?>
+      <span class="edit"><?php echo $editlink; ?></span>
+    <?php } ?>
     <?php if ($grade) { ?>
       <div class="grade">
         <?php echo get_string('marks', 'quiz').': '.$grade; ?>
diff --git a/question/type/truefalse/display.html b/question/type/truefalse/display.html
index 99d9688ba5..7c5d02d879 100644
--- a/question/type/truefalse/display.html
+++ b/question/type/truefalse/display.html
@@ -25,6 +25,4 @@
 		</div>
 	<?php } ?>
 	<?php $this->print_question_submit_buttons($question, $state, $cmoptions, $options); ?>
-</div>
-
-</div>
+</div>
\ No newline at end of file
-- 
2.39.5