From 64874c5aacf05881c5d07ae59e24448f9343817f Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Sat, 29 Dec 2007 16:38:25 +0000
Subject: [PATCH] MDL-12752 making unsupported pages truly hidden; merged from
 MOODLE_19_STABLE

---
 admin/settings/unsupported.php | 8 ++++----
 lib/adminlib.php               | 3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/admin/settings/unsupported.php b/admin/settings/unsupported.php
index 5c037ab66f..9d095b3bda 100644
--- a/admin/settings/unsupported.php
+++ b/admin/settings/unsupported.php
@@ -4,10 +4,10 @@
 
 if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
 
-    $ADMIN->add('unsupported', new admin_externalpage('purgemoodledata', 'Purge moodledata', $CFG->wwwroot.'/'.$CFG->admin.'/delete.php'));
-    $ADMIN->add('unsupported', new admin_externalpage('healthcenter', get_string('healthcenter'), $CFG->wwwroot.'/'.$CFG->admin.'/health.php'));
-    $ADMIN->add('unsupported', new admin_externalpage('toinodb', 'Convert to InnoDB', $CFG->wwwroot.'/'.$CFG->admin.'/innodb.php'));
-    $ADMIN->add('unsupported', new admin_externalpage('replace', 'Search and replace', $CFG->wwwroot.'/'.$CFG->admin.'/replace.php'));
+    $ADMIN->add('unsupported', new admin_externalpage('purgemoodledata', 'Purge moodledata', $CFG->wwwroot.'/'.$CFG->admin.'/delete.php', 'moodle/site:config', true));
+    $ADMIN->add('unsupported', new admin_externalpage('healthcenter', get_string('healthcenter'), $CFG->wwwroot.'/'.$CFG->admin.'/health.php', 'moodle/site:config', true));
+    $ADMIN->add('unsupported', new admin_externalpage('toinodb', 'Convert to InnoDB', $CFG->wwwroot.'/'.$CFG->admin.'/innodb.php', 'moodle/site:config', true));
+    $ADMIN->add('unsupported', new admin_externalpage('replace', 'Search and replace', $CFG->wwwroot.'/'.$CFG->admin.'/replace.php', 'moodle/site:config', true));
 
 } // end of speedup
 
diff --git a/lib/adminlib.php b/lib/adminlib.php
index 5c2bfd920c..dea854e25a 100644
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -4181,7 +4181,8 @@ function admin_search_settings_html($query) {
     foreach ($findings as $found) {
         $page     = $found->page;
         $settings = $found->settings;
-        if ($page->hidden) {
+        if ($page->is_hidden()) {
+            // hidden pages are not displayed in search results
             continue;
         }
         if (is_a($page, 'admin_externalpage')) {
-- 
2.39.5