From 64eeaf47536a106fca335e70d9a0f0bb636701f8 Mon Sep 17 00:00:00 2001 From: jamiesensei Date: Mon, 7 May 2007 07:13:14 +0000 Subject: [PATCH] removed all session fromurl and returnurl stuff from question bank editing code. Returnurls are now passed as get/post params. --- mod/quiz/edit.php | 1 - question/edit.php | 1 - question/editlib.php | 4 +--- question/question.php | 4 +--- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/mod/quiz/edit.php b/mod/quiz/edit.php index 61bac657fe..c9f608f72a 100644 --- a/mod/quiz/edit.php +++ b/mod/quiz/edit.php @@ -72,7 +72,6 @@ $quiz->grades = quiz_get_all_question_grades($quiz); } - $SESSION->returnurl = $FULLME; /// Now, check for commands on this page and modify variables as necessary diff --git a/question/edit.php b/question/edit.php index 2858b5d82e..790a5c5d94 100644 --- a/question/edit.php +++ b/question/edit.php @@ -20,7 +20,6 @@ } $context = get_context_instance(CONTEXT_COURSE, $courseid); - $SESSION->returnurl = $FULLME; $streditingquestions = get_string('editquestions', "quiz"); if ($cm!==null) { diff --git a/question/editlib.php b/question/editlib.php index 146a927852..904d497e78 100644 --- a/question/editlib.php +++ b/question/editlib.php @@ -425,9 +425,7 @@ function question_list($course, $pageurl, $categoryid, $cm = null, * @param moodle_url $pageurl object representing this pages url. */ function question_showbank($pageurl, $cm, $page, $perpage, $sortorder, $sortorderdecoded, $cat, $recurse, $showhidden, $showquestiontext){ - global $SESSION, $COURSE; - - $SESSION->fromurl = $pageurl->out(); + global $COURSE; /// Now, check for commands on this page and modify variables as necessary if (isset($_REQUEST['move']) and confirm_sesskey()) { /// Move selected questions to new category diff --git a/question/question.php b/question/question.php index 1c8cf70c7c..ea21642b5e 100644 --- a/question/question.php +++ b/question/question.php @@ -14,9 +14,7 @@ require_once($CFG->libdir . '/filelib.php'); require_once($CFG->libdir . '/formslib.php'); $returnurl = optional_param('returnurl', 0, PARAM_URL); -if (!$returnurl && isset($SESSION->fromurl)) { - $returnurl = $SESSION->fromurl; -} + // Read URL parameters telling us which question to edit. $id = optional_param('id', 0, PARAM_INT); // question id $cmid = optional_param('cmid', 0, PARAM_INT); -- 2.39.5