From 69cd298a276f2409b5f6b65f215bb22d27d1f303 Mon Sep 17 00:00:00 2001 From: skodak Date: Thu, 9 Nov 2006 23:35:06 +0000 Subject: [PATCH] code improvement in count_courses_notin_metacourse() MDL-7424 - thanks Eloy! --- lib/datalib.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/datalib.php b/lib/datalib.php index eff8d5d9e7..da397858d9 100644 --- a/lib/datalib.php +++ b/lib/datalib.php @@ -102,15 +102,15 @@ function count_courses_notin_metacourse($metacourseid) { $alreadycourses = get_courses_in_metacourse($metacourseid); - $sql = "SELECT 1, COUNT(c.id) AS notin FROM {$CFG->prefix}course c + $sql = "SELECT COUNT(c.id) AS notin FROM {$CFG->prefix}course c WHERE ".((!empty($alreadycourses)) ? "c.id NOT IN (".implode(',',array_keys($alreadycourses)).") AND " : "")." c.id !=$metacourseid and c.id != ".SITEID." and c.metacourse != 1"; - if (!$result = get_records_sql($sql)) { + if (!$count = get_record_sql($sql)) { return 0; } - return $result[1]->notin; + return $count->notin; } /** -- 2.39.5