From 6ccaf3f5e5b84ab9921bc67b3681edcc59326b83 Mon Sep 17 00:00:00 2001 From: Petr Skoda Date: Sun, 8 Nov 2009 21:39:10 +0000 Subject: [PATCH] MDL-20625 fixed transaction related todos --- group/externallib.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/group/externallib.php b/group/externallib.php index 74ac1e4fa3..b3074e9fdc 100644 --- a/group/externallib.php +++ b/group/externallib.php @@ -239,8 +239,7 @@ class moodle_group_external extends external_api { $transaction = $DB->start_delegated_transaction(); -// TODO: this is problematic because the DB rollback does not handle deleting of images!! -// there is also potential problem with events propagating action to external systems :-( +// TODO: this is problematic because the DB rollback does not handle deleting of group images! foreach ($params['groupids'] as $groupid) { // validate params $groupid = validate_param($groupid, PARAM_INTEGER); @@ -354,7 +353,6 @@ class moodle_group_external extends external_api { $params = self::validate_parameters(self::add_groupmembers_parameters(), array('members'=>$members)); $transaction = $DB->start_delegated_transaction(); - // TODO: there is a potential problem with events propagating action to external systems :-( foreach ($params['members'] as $member) { // validate params $groupid = $member['groupid']; @@ -419,7 +417,6 @@ class moodle_group_external extends external_api { $transaction = $DB->start_delegated_transaction(); -// TODO: there is a potential problem with events propagating action to external systems :-( foreach ($params['members'] as $member) { // validate params $groupid = $member['groupid']; -- 2.39.5