From 6cf05835011ac282ee9321336c8d3deb6bcb8a57 Mon Sep 17 00:00:00 2001 From: stronk7 Date: Sat, 12 Jan 2008 18:54:30 +0000 Subject: [PATCH] Function changed to check for register_globals. MDL-12914 ; merged from 19_STABLE --- lib/customcheckslib.php | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/customcheckslib.php b/lib/customcheckslib.php index 38c36f59f3..ead8e83ce8 100644 --- a/lib/customcheckslib.php +++ b/lib/customcheckslib.php @@ -35,15 +35,23 @@ /// - false: if failed /** - * This function will look for some risky PHP settings combinations - * in order to inform about. + * This function will look for the risky PHP setting register_globals + * in order to inform about. MDL-12914 * * @param $result the environment_results object to be modified * @return mixed null if the test is irrelevant or environment_results object with * status set to true (test passed) or false (test failed) */ -function php_check_register_globals_and_fopen($result) { - return null; +function php_check_register_globals($result) { + +/// Check for register_globals. If enabled, security warning + if (ini_get_bool('register_globals')) { + $result->status = false; + } else { + $result = null; + } + + return $result; } ?> -- 2.39.5