From 6d2382b6d7edce9efd54643513e569387a6df86a Mon Sep 17 00:00:00 2001 From: poltawski Date: Fri, 31 Jul 2009 21:19:37 +0000 Subject: [PATCH] blocks/rss_client: MDL-13932 fix config_shownumentries typo This caused incorrect rules/defaults to be added Also add client side validation of the number --- blocks/rss_client/edit_form.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/blocks/rss_client/edit_form.php b/blocks/rss_client/edit_form.php index 23980d5f4e..e84397e789 100644 --- a/blocks/rss_client/edit_form.php +++ b/blocks/rss_client/edit_form.php @@ -40,11 +40,12 @@ class block_rss_client_edit_form extends block_edit_form { $mform->setDefault('config_display_description', 0); $mform->addElement('text', 'config_shownumentries', get_string('shownumentrieslabel', 'block_rss_client'), array('size' => 5)); - $mform->setType('config_text', PARAM_INTEGER); + $mform->setType('config_shownumentries', PARAM_INTEGER); + $mform->addRule('config_shownumentries', null, 'numeric', null, 'client'); if (!empty($CFG->block_rss_client_num_entries)) { - $mform->setDefault('config_text', $CFG->block_rss_client_num_entries); + $mform->setDefault('config_shownumentries', $CFG->block_rss_client_num_entries); } else { - $mform->setDefault('config_text', 5); + $mform->setDefault('config_shownumentries', 5); } $rssfeeds = $DB->get_records_sql_menu(' -- 2.39.5