From 7003072a7fd0a8409a62ea3ced5333ff9653e2b6 Mon Sep 17 00:00:00 2001
From: tjhunt <tjhunt>
Date: Thu, 10 Aug 2006 18:58:26 +0000
Subject: [PATCH] Fix minor HTML validation issue.

---
 lib/weblib.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/weblib.php b/lib/weblib.php
index 09a164d246..632f548b77 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -718,7 +718,8 @@ function choose_from_menu ($options, $name, $selected='', $nothing='choose', $sc
         $attributes .= ' tabindex="'.$tabindex.'"';
     }
 
-    $output = '<select id="menu'.$name.'" name="'. $name .'" '. $attributes .'>' . "\n";
+    $id = str_replace('[]', '', $name); // name may end in [], which would make an invalid id. e.g. numeric question type editing form.
+    $output = '<select id="menu'.$id.'" name="'. $name .'" '. $attributes .'>' . "\n";
     if ($nothing) {
         $output .= '   <option value="'. $nothingvalue .'"'. "\n";
         if ($nothingvalue === $selected) {
-- 
2.39.5