From 71106544b376102ec5aa1c1dbe0aa4f35131fd14 Mon Sep 17 00:00:00 2001 From: nicolasconnault Date: Tue, 28 Jul 2009 09:33:14 +0000 Subject: [PATCH] MDL-19817 Migrated choose_from_menu to the new $OUTPUT->select_menu() function --- mod/wiki/admin.php | 7 ++++++- mod/wiki/view.php | 8 ++++++-- mod/wiki/wiki.js | 3 +++ 3 files changed, 15 insertions(+), 3 deletions(-) create mode 100644 mod/wiki/wiki.js diff --git a/mod/wiki/admin.php b/mod/wiki/admin.php index f419048109..73cead33b7 100644 --- a/mod/wiki/admin.php +++ b/mod/wiki/admin.php @@ -285,7 +285,12 @@ while(list($key,$val)=each($wiki_list)) { $wiki_admin_list[$key."&action=$action"]=$val; } - choose_from_menu($wiki_admin_list, "wikiselect", $selected, "choose", $script); + $selectmenu = new moodle_select_menu(); + $selectmenu->options = $wiki_admin_list; + $selectmenu->name = 'wikiselect'; + $selectmenu->selectedvalue = $selected; + $selectmenu->add_action('change', 'go_to_wiki'); + echo $OUTPUT->select_menu($selectmenu); echo ''; echo ''; echo ''; diff --git a/mod/wiki/view.php b/mod/wiki/view.php index dbc4ef710e..785ea9c196 100644 --- a/mod/wiki/view.php +++ b/mod/wiki/view.php @@ -300,8 +300,12 @@ echo '' .get_string('otherwikis', 'wiki').':  '; - $script = 'self.location=getElementById(\'otherwikis\').wikiselect.options[getElementById(\'otherwikis\').wikiselect.selectedIndex].value'; - choose_from_menu($wiki_list, "wikiselect", $selected, "choose", $script); + $selectmenu = new moodle_select_menu(); + $selectmenu->options = $wiki_list; + $selectmenu->name = 'wikiselect'; + $selectmenu->selectedvalue = $selected; + $selectmenu->add_action('change', 'go_to_wiki'); + echo $OUTPUT->select_menu($selectmenu); echo ''; echo ''; echo ''; diff --git a/mod/wiki/wiki.js b/mod/wiki/wiki.js new file mode 100644 index 0000000000..db737d0bcf --- /dev/null +++ b/mod/wiki/wiki.js @@ -0,0 +1,3 @@ +function go_to_wiki(e, args) { + self.location = e.target.value; +} -- 2.39.5