From 7520988bb314b725c929d0544856c39780057d9a Mon Sep 17 00:00:00 2001 From: moodler Date: Tue, 15 Oct 2002 17:13:11 +0000 Subject: [PATCH] Fixes for grades --- mod/quiz/db/mysql.sql | 9 +++++---- mod/quiz/lib.php | 2 ++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/mod/quiz/db/mysql.sql b/mod/quiz/db/mysql.sql index 9755e761a7..c5f46617ab 100644 --- a/mod/quiz/db/mysql.sql +++ b/mod/quiz/db/mysql.sql @@ -3,7 +3,7 @@ # http://www.phpmyadmin.net/ (download page) # # Host: localhost -# Generation Time: Oct 16, 2002 at 12:20 AM +# Generation Time: Oct 16, 2002 at 01:12 AM # Server version: 3.23.49 # PHP Version: 4.2.3 # Database : `moodle` @@ -43,6 +43,7 @@ CREATE TABLE `quiz_answers` ( `answer` varchar(255) NOT NULL default '', `fraction` varchar(10) NOT NULL default '0.0', `feedback` varchar(255) NOT NULL default '', + PRIMARY KEY (`id`) ) TYPE=MyISAM COMMENT='Answers, with a fractional grade (0-1) and feedback'; # -------------------------------------------------------- @@ -56,7 +57,7 @@ CREATE TABLE `quiz_attempts` ( `quiz` int(10) unsigned NOT NULL default '0', `user` int(10) unsigned NOT NULL default '0', `attempt` smallint(6) NOT NULL default '0', - `sumgrades` int(10) NOT NULL default '0', + `sumgrades` varchar(10) NOT NULL default '0.0', `timemodified` int(10) unsigned NOT NULL default '0', PRIMARY KEY (`id`) ) TYPE=MyISAM COMMENT='Stores various attempts on a quiz'; @@ -84,7 +85,7 @@ CREATE TABLE `quiz_grades` ( `id` int(10) unsigned NOT NULL auto_increment, `quiz` int(10) unsigned NOT NULL default '0', `user` int(10) unsigned NOT NULL default '0', - `grade` int(10) NOT NULL default '0', + `grade` varchar(10) NOT NULL default '0.0', `timemodified` int(10) unsigned NOT NULL default '0', PRIMARY KEY (`id`) ) TYPE=MyISAM COMMENT='Final quiz grade (may be best of several attempts)'; @@ -142,7 +143,7 @@ CREATE TABLE `quiz_responses` ( `attempt` int(10) unsigned NOT NULL default '0', `question` int(10) unsigned NOT NULL default '0', `answer` varchar(255) NOT NULL default '', - `grade` int(10) NOT NULL default '0', + `grade` varchar(10) NOT NULL default '0.0', PRIMARY KEY (`id`) ) TYPE=MyISAM COMMENT='Stores user responses to a quiz, and percentage grades'; # -------------------------------------------------------- diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php index debfc69a43..acb2191ddb 100644 --- a/mod/quiz/lib.php +++ b/mod/quiz/lib.php @@ -704,6 +704,7 @@ function quiz_save_attempt($quiz, $questions, $result, $attemptnum) { $attempt->timemodified = time(); if (!$attempt->id = insert_record("quiz_attempts", $attempt)) { + notify("Error while saving attempt"); return false; } @@ -719,6 +720,7 @@ function quiz_save_attempt($quiz, $questions, $result, $attemptnum) { $response->answer = ""; } if (!insert_record("quiz_responses", $response)) { + notify("Error while saving response"); return false; } } -- 2.39.5