From 82fd2e8bfb0dbac1898ed6d9bf2b85bac81e26ba Mon Sep 17 00:00:00 2001 From: tjhunt Date: Wed, 22 Jul 2009 09:25:46 +0000 Subject: [PATCH] quiz: Check this is the users own attempt before sending them to the attempt.php page. --- mod/quiz/review.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mod/quiz/review.php b/mod/quiz/review.php index 619f0a0b20..6fd1227170 100644 --- a/mod/quiz/review.php +++ b/mod/quiz/review.php @@ -27,14 +27,14 @@ /// Permissions checks for normal users who do not have quiz:viewreports capability. if (!$attemptobj->has_capability('mod/quiz:viewreports')) { + /// Can't review other users' attempts. + if (!$attemptobj->is_own_attempt()) { + quiz_error($attemptobj->get_quiz(), 'notyourattempt'); + } /// Can't review during the attempt - send them back to the attempt page. if (!$attemptobj->is_finished()) { redirect($attemptobj->attempt_url(0, $page)); } - /// Can't review other users' attempts. - if (!$attemptobj->is_own_attempt()) { - quiz_error($quiz, 'notyourattempt'); - } /// Can't review unless Students may review -> Responses option is turned on. if (!$options->responses) { $accessmanager->back_to_view_page($attemptobj->is_preview_user(), @@ -99,7 +99,6 @@ } /// Print heading. - print_heading(format_string($attemptobj->get_quiz_name())); if ($attemptobj->is_preview_user() && $attemptobj->is_own_attempt()) { $attemptobj->print_restart_preview_button(); } -- 2.39.5