From 858deff0b4acd0ffd467a06d6a9a0ef8a78d065a Mon Sep 17 00:00:00 2001 From: moodler Date: Thu, 17 Oct 2002 07:55:54 +0000 Subject: [PATCH] Now includes maximum grades --- course/grades.php | 17 +++++++++++++---- mod/assignment/lib.php | 6 ++++-- mod/quiz/lib.php | 7 +++++-- 3 files changed, 22 insertions(+), 8 deletions(-) diff --git a/course/grades.php b/course/grades.php index 6d80221182..3242f9458e 100644 --- a/course/grades.php +++ b/course/grades.php @@ -18,6 +18,7 @@ $strgrades = get_string("grades"); $strgrade = get_string("grade"); + $strmax = get_string("maximumshort"); /// Otherwise fill and print the form. @@ -56,6 +57,14 @@ require_once($libfile); $gradefunction = $mod->modname."_grades"; if (function_exists($gradefunction)) { // Skip modules without grade function + $modgrades = $gradefunction($mod->instance); + + if ($modgrades->maxgrade) { + $maxgrade = "
$strmax: $modgrades->maxgrade"; + } else { + $maxgrade = ""; + } + $image = "wwwroot/mod/$mod->modname/view.php?id=$mod->id\"". " TITLE=\"$mod->modfullname\">". "modname/icon.gif\" ". @@ -63,12 +72,10 @@ $columns[] = "$image ". "wwwroot/mod/$mod->modname/view.php?id=$mod->id\">". "$instance->name". - ""; - - $modgrades = $gradefunction($mod->instance); + "$maxgrade"; foreach ($students as $student) { - $grades[$student->id][] = $modgrades[$student->id]->grade; // may be empty, that's ok + $grades[$student->id][] = $modgrades->grades[$student->id]; // may be empty, that's ok } } } @@ -90,6 +97,8 @@ $student = $students[$studentid]; $picture = print_user_picture($student->id, $course->id, $student->picture, false, true); $name = array ("$picture", "$student->firstname $student->lastname"); + + $table->data[] = array_merge($name, $gradelist); } diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php index f067aabfa7..787142e998 100644 --- a/mod/assignment/lib.php +++ b/mod/assignment/lib.php @@ -218,9 +218,11 @@ function assignment_print_recent_activity(&$logs, $isteacher=false) { } function assignment_grades($assignmentid) { -/// Must return an array of grades, indexed by user. The grade is called "grade". +/// Must return an array of grades, indexed by user, and a max grade. - return get_records("assignment_submissions", "assignment", $assignmentid, "user ASC", "user,grade"); + $return->grades = get_records_sql_menu("SELECT user,grade FROM assignment_submissions WHERE assignment = '$assignmentid'"); + $return->maxgrade = get_field("assignment", "grade", "id", "$assignmentid"); + return $return; } ////////////////////////////////////////////////////////////////////////////////////// diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php index 454389939f..f2fce6515c 100644 --- a/mod/quiz/lib.php +++ b/mod/quiz/lib.php @@ -186,8 +186,11 @@ function quiz_cron () { } function quiz_grades($quizid) { -/// Must return an array of grades, indexed by user. The grade is called "grade". - return get_records("quiz_grades", "quiz", $quizid, "user ASC", "user,grade"); +/// Must return an array of grades, indexed by user, and a max grade. + + $return->grades = get_records_sql_menu("SELECT user,grade FROM quiz_grades WHERE quiz = '$quizid'"); + $return->maxgrade = get_field("quiz", "grade", "id", "$quizid"); + return $return; } -- 2.39.5