From 859b33cfd4b6dc709d57659ffb7429136cc8c812 Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Fri, 18 Apr 2008 18:52:13 +0000
Subject: [PATCH] MDL-13936 users without accessallgroups can post start
 discussions only in own groups if groupmode enabled in forum (either separate
 or visible), this was the way it worked in Moodle <1.8; merged from
 MOODLE_19_STABLE

---
 mod/forum/lib.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
index b5e0fa79bc..d5b2158f9e 100644
--- a/mod/forum/lib.php
+++ b/mod/forum/lib.php
@@ -4249,12 +4249,9 @@ function forum_user_can_post_discussion($forum, $currentgroup=null, $unused=-1,
     if ($currentgroup) {
         return groups_is_member($currentgroup);
     } else {
-        //else it might be group 0 in visible mode
-        if ($groupmode == VISIBLEGROUPS){
-            return true;
-        } else {
-            return false;
-        }
+        // no group membership and no accessallgroups means no new discussions
+        // reverted to 1.7 behaviour in 1.9+,  buggy in 1.8.0-1.9.0
+        return false;
     }
 }
 
-- 
2.39.5