From 87f83794a4038527ef424486c7bf05101921cc0e Mon Sep 17 00:00:00 2001 From: samhemelryk Date: Thu, 24 Sep 2009 08:05:55 +0000 Subject: [PATCH] mod-lesson MDL-19812 Added set_url calls, replaced deprecated functions --- mod/lesson/grade.php | 4 +++- mod/lesson/highscores.php | 13 +++++++++++-- mod/lesson/import.php | 17 ++++++++++++++--- mod/lesson/importppt.php | 16 +++++++++++++--- mod/lesson/index.php | 6 ++++-- mod/lesson/locallib.php | 14 ++++++++++---- mod/lesson/mediafile.php | 12 +++++++++--- 7 files changed, 64 insertions(+), 18 deletions(-) diff --git a/mod/lesson/grade.php b/mod/lesson/grade.php index 4e1ebdab4e..33a4f38910 100644 --- a/mod/lesson/grade.php +++ b/mod/lesson/grade.php @@ -1,9 +1,11 @@ -set_url(new moodle_url($CFG->wwwroot.'/mod/lesson/grade.php', array('id'=>$id))); + if (! $cm = get_coursemodule_from_id('lesson', $id)) { print_error('invalidcoursemodule'); } diff --git a/mod/lesson/highscores.php b/mod/lesson/highscores.php index d0569c4fd9..af73634c71 100644 --- a/mod/lesson/highscores.php +++ b/mod/lesson/highscores.php @@ -1,8 +1,8 @@ -wwwroot.'/mod/lesson/highscores.php', array('id'=>$id)); + if ($mode !== '') { + $url->param('mode', $mode); + } + if ($link !== 0) { + $url->param('link', $link); + } + $PAGE->set_url($url); + list($cm, $course, $lesson) = lesson_get_basics($id); require_login($course->id, false, $cm); diff --git a/mod/lesson/import.php b/mod/lesson/import.php index 1358e8ed23..2e6fdcd9e8 100644 --- a/mod/lesson/import.php +++ b/mod/lesson/import.php @@ -1,8 +1,8 @@ -wwwroot.'/mod/lesson/import.php', array('id'=>$id)); + if ($pageid !== '') { + $url->param('pageid', $pageid); + } + $PAGE->set_url($url); + if (! $cm = get_coursemodule_from_id('lesson', $id)) { print_error('invalidcoursemodule'); } @@ -86,7 +92,12 @@ $fileformatnames = get_import_export_formats('import'); - print_heading_with_help($strimportquestions, "import", "lesson"); + $helpicon = new moodle_help_icon(); + $helpicon->text = $strimportquestions; + $helpicon->page = "import"; + $helpicon->module = "lesson"; + + echo $OUTPUT->heading_with_help($helpicon); echo $OUTPUT->box_start('generalbox boxaligncenter'); echo "
"; diff --git a/mod/lesson/importppt.php b/mod/lesson/importppt.php index 2a92304f14..125c92c5c3 100644 --- a/mod/lesson/importppt.php +++ b/mod/lesson/importppt.php @@ -1,4 +1,5 @@ -wwwroot.'/mod/lesson/importppt.php', array('id'=>$id)); + if ($pageid !== '') { + $url->param('pageid', $pageid); + } + $PAGE->set_url($url); if (! $cm = get_coursemodule_from_id('lesson', $id)) { print_error('invalidcoursemodule'); @@ -84,8 +90,12 @@ } /// Print upload form + $helpicon = new moodle_help_icon(); + $helpicon->text = $strimportppt; + $helpicon->page = "importppt"; + $helpicon->module = "lesson"; - print_heading_with_help($strimportppt, "importppt", "lesson"); + echo $OUTPUT->heading_with_help($helpicon); echo $OUTPUT->box_start('generalbox boxaligncenter'); echo ""; diff --git a/mod/lesson/index.php b/mod/lesson/index.php index f707ae3ca0..75210af80e 100644 --- a/mod/lesson/index.php +++ b/mod/lesson/index.php @@ -1,8 +1,8 @@ -set_url(new moodle_url($CFG->wwwroot.'/mod/lesson/index.php', array('id'=>$id))); + if (!$course = $DB->get_record("course", array("id" => $id))) { print_error('invalidcourseid'); } diff --git a/mod/lesson/locallib.php b/mod/lesson/locallib.php index f02fb2bb8b..eb68cd4ff8 100644 --- a/mod/lesson/locallib.php +++ b/mod/lesson/locallib.php @@ -1,9 +1,9 @@ -id); if (has_capability('mod/lesson:edit', $context)) { - $buttons = update_module_button($cm->id, $course->id, get_string('modulename', 'lesson')); + $buttons = $OUTPUT->update_module_button($cm->id, 'lesson'); if ($extraeditbuttons) { if ($lessonpageid === NULL) { print_error('invalidpageid', 'lesson'); @@ -266,7 +266,13 @@ function lesson_print_header($cm, $course, $lesson, $currenttab = '', $extraedit echo $OUTPUT->header(); if (has_capability('mod/lesson:manage', $context)) { - print_heading_with_help($activityname, 'overview', 'lesson'); + + $helpicon = new moodle_help_icon(); + $helpicon->text = $activityname; + $helpicon->page = "overview"; + $helpicon->module = "lesson"; + + echo $OUTPUT->heading_with_help($helpicon); if (!empty($currenttab)) { include($CFG->dirroot.'/mod/lesson/tabs.php'); diff --git a/mod/lesson/mediafile.php b/mod/lesson/mediafile.php index af39fdffdd..2cae8242a6 100644 --- a/mod/lesson/mediafile.php +++ b/mod/lesson/mediafile.php @@ -1,4 +1,5 @@ -wwwroot.'/mod/lesson/mediafile.php', array('id'=>$id)); + if ($printclose !== '') { + $url->param('printclose', $printclose); + } + $PAGE->set_url($url); + if (! $cm = get_coursemodule_from_id('lesson', $id)) { print_error('invalidcoursemodule'); } -- 2.39.5