From 8ff79e8c5bc89b286184aabf98a09029428c5fb4 Mon Sep 17 00:00:00 2001
From: moodler <moodler>
Date: Fri, 30 Jan 2004 16:53:01 +0000
Subject: [PATCH] Fixed the counting of submissions for a new function
 assignment_count_real_submissions()

---
 mod/assignment/index.php |  2 +-
 mod/assignment/lib.php   | 17 ++++++++++++++++-
 mod/assignment/view.php  |  2 +-
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/mod/assignment/index.php b/mod/assignment/index.php
index f443167306..5c16ee0822 100644
--- a/mod/assignment/index.php
+++ b/mod/assignment/index.php
@@ -53,7 +53,7 @@
                 $submitted =  "<a href=\"submissions.php?id=$assignment->id\">" .
                                 get_string("viewfeedback", "assignment") . "</a>";
             } else {
-                $count = count(assignment_get_all_submissions($assignment));
+                $count = assignment_count_real_submissions($assignment);
                 $submitted = "<a href=\"submissions.php?id=$assignment->id\">" .
                              get_string("viewsubmissions", "assignment", $count) . "</A>";
             }
diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php
index 8a8e666d94..ceff2480cb 100644
--- a/mod/assignment/lib.php
+++ b/mod/assignment/lib.php
@@ -308,8 +308,23 @@ function assignment_log_info($log) {
                               AND u.id = '$log->userid'");
 }
 
+function assignment_count_real_submissions($assignment) {
+/// Return all real assignment submissions by ENROLLED students (not empty ones)
+    global $CFG;
+
+    return count_records_sql("SELECT count(a.id)
+                              FROM {$CFG->prefix}assignment_submissions a, 
+                                   {$CFG->prefix}user_students s,
+                                   {$CFG->prefix}user u
+                             WHERE a.userid = s.userid
+                               AND u.id = a.userid
+                               AND s.course = '$assignment->course'
+                               AND a.assignment = '$assignment->id' 
+                               AND a.timemodified > 0");
+}
+
 function assignment_get_all_submissions($assignment, $sort="", $dir="DESC") {
-/// Return all assignment submissions by ENROLLED students
+/// Return all assignment submissions by ENROLLED students (even empty)
     global $CFG;
 
     if ($sort == "lastname" or $sort == "firstname") {
diff --git a/mod/assignment/view.php b/mod/assignment/view.php
index 8b440cc522..28df88b6e8 100644
--- a/mod/assignment/view.php
+++ b/mod/assignment/view.php
@@ -52,7 +52,7 @@
             echo "<a href=\"submissions.php?id=$assignment->id\">".
                   get_string("viewfeedback", "assignment")."</a>";
         } else {
-            $count = count(assignment_get_all_submissions($assignment));
+            $count = assignment_count_real_submissions($assignment);
             echo "<a href=\"submissions.php?id=$assignment->id\">".
                   get_string("viewsubmissions", "assignment", $count)."</a>";
         }
-- 
2.39.5