From 9509119b0e0a458b36c909c2ac4c82d36528edde Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Mon, 19 Nov 2007 21:41:02 +0000
Subject: [PATCH] MDL-12249 fixed small group ration, can be overriden from
 config.php now; merged from MOODLE_19_STABLE

---
 group/autogroup.php | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/group/autogroup.php b/group/autogroup.php
index 73b9631637..f3f299ebaf 100644
--- a/group/autogroup.php
+++ b/group/autogroup.php
@@ -12,7 +12,9 @@ require_once('../config.php');
 require_once('lib.php');
 require_once('autogroup_form.php');
 
-define('AUTOGROUP_MIN_RATIO', 0.7);
+if (!defined('AUTOGROUP_MIN_RATIO')) {
+    define('AUTOGROUP_MIN_RATIO', 0.7); // means minimum member count is 70% in the smallest group
+}
 
 $courseid = required_param('courseid', PARAM_INT);
 
@@ -104,7 +106,7 @@ if ($editform->is_cancelled()) {
         if (!empty($data->nosmallgroups) and $usercnt % $data->number != 0) {
             // If there would be one group with a small number of member reduce the number of groups
             $missing = $userpergrp * $numgrps - $usercnt;
-            if ($missing > $userpergrp * AUTOGROUP_MIN_RATIO) {
+            if ($missing > $userpergrp * (1-AUTOGROUP_MIN_RATIO)) {
                 $numgrps--;
                 $userpergrp = ceil($usercnt/$numgrps);
             }
-- 
2.39.5