From 9b0b537b695d6982b7c1348f2b1e162bcd03bd60 Mon Sep 17 00:00:00 2001 From: skodak Date: Thu, 15 Jan 2009 18:30:26 +0000 Subject: [PATCH] MDL-17222 imrpoved configuration links --- admin/report/security/index.php | 2 +- admin/report/security/lib.php | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/admin/report/security/index.php b/admin/report/security/index.php index 19b626f361..9dc838b66e 100644 --- a/admin/report/security/index.php +++ b/admin/report/security/index.php @@ -76,7 +76,7 @@ if ($issue and ($result = $issue(true))) { $row[0] = $result->name; $row[1] = $statusarr[$result->status]; $row[2] = $result->info; - $row[3] = is_null($result->link) ? '-' : "$strconfig"; + $row[3] = is_null($result->link) ? ' ' : $result->link; $table->data[] = $row; diff --git a/admin/report/security/lib.php b/admin/report/security/lib.php index 7232e5f323..75561b761b 100644 --- a/admin/report/security/lib.php +++ b/admin/report/security/lib.php @@ -107,7 +107,7 @@ function report_security_check_noauth($detailed=false) { $result->details = null; $result->status = null; $result->link = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=manageauths"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=manageauths\">".get_string('authsettings', 'admin').''; if (is_enabled_auth('none')) { $result->status = REPORT_SECURITY_CRITICAL; @@ -138,7 +138,7 @@ function report_security_check_passwordpolicy($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=sitepolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=sitepolicies\">".get_string('sitepolicies', 'admin').''; if (empty($CFG->passwordpolicy)) { $result->status = REPORT_SECURITY_WARNING; @@ -169,7 +169,7 @@ function report_security_check_embed($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=sitepolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=sitepolicies\">".get_string('sitepolicies', 'admin').''; if (!empty($CFG->allowobjectembed)) { $result->status = REPORT_SECURITY_CRITICAL; @@ -200,7 +200,7 @@ function report_security_check_mediafilterswf($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=filtersettingfiltermediaplugin"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=filtersettingfiltermediaplugin\">".get_string('filtersettings', 'admin').''; if (!empty($CFG->textfilters)) { $activefilters = explode(',', $CFG->textfilters); @@ -305,7 +305,7 @@ function report_security_check_openprofiles($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=sitepolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=sitepolicies\">".get_string('sitepolicies', 'admin').''; if (empty($CFG->forcelogin) and empty($CFG->forceloginforprofiles)) { $result->status = REPORT_SECURITY_WARNING; @@ -337,7 +337,7 @@ function report_security_check_google($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=sitepolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=sitepolicies\">".get_string('sitepolicies', 'admin').''; if (empty($CFG->opentogoogle)) { $result->status = REPORT_SECURITY_OK; @@ -371,7 +371,7 @@ function report_security_check_emailchangeconfirmation($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=sitepolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=sitepolicies\">".get_string('sitepolicies', 'admin').''; if (empty($CFG->emailchangeconfirmation)) { $result->status = REPORT_SECURITY_WARNING; @@ -407,7 +407,7 @@ function report_security_check_cookiesecure($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=httpsecurity"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=httpsecurity\">".get_string('httpsecurity', 'admin').''; if (empty($CFG->cookiesecure)) { $result->status = REPORT_SECURITY_SERIOUS; @@ -515,7 +515,7 @@ function report_security_check_defaultuserrole($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=userpolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=userpolicies\">".get_string('userpolicies', 'admin').'';; if (!$default_role = $DB->get_record('role', array('id'=>$CFG->defaultuserroleid))) { $result->status = REPORT_SECURITY_WARNING; @@ -594,7 +594,7 @@ function report_security_check_guestrole($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=userpolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=userpolicies\">".get_string('userpolicies', 'admin').'';; if (!$guest_role = $DB->get_record('role', array('id'=>$CFG->guestroleid))) { $result->status = REPORT_SECURITY_WARNING; @@ -670,7 +670,7 @@ function report_security_check_frontpagerole($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=frontpagesettings"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=frontpagesettings\">".get_string('frontpagesettings','admin').'';; if (!$frontpage_role = $DB->get_record('role', array('id'=>$CFG->defaultfrontpageroleid))) { $result->status = REPORT_SECURITY_INFO; @@ -746,7 +746,7 @@ function report_security_check_defaultcourserole($detailed=false) { $result->info = null; $result->details = null; $result->status = null; - $result->link = "$CFG->wwwroot/$CFG->admin/settings.php?section=userpolicies"; + $result->link = "wwwroot/$CFG->admin/settings.php?section=userpolicies\">".get_string('userpolicies', 'admin').'';; if ($detailed) { $result->details = get_string('check_defaultcourserole_details', 'report_security'); -- 2.39.5