From a1244706bed33b37372b3bc2bde963ed379edc79 Mon Sep 17 00:00:00 2001 From: martinlanghoff Date: Wed, 19 Sep 2007 07:01:41 +0000 Subject: [PATCH] user_set_preference(): minor optimisation Don't update if the values already match... --- lib/moodlelib.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/moodlelib.php b/lib/moodlelib.php index af94426421..3d63fd57e8 100644 --- a/lib/moodlelib.php +++ b/lib/moodlelib.php @@ -786,6 +786,9 @@ function set_user_preference($name, $value, $otheruserid=NULL) { // no pernament storage for not-logged-in user and guest } else if ($preference = get_record('user_preferences', 'userid', $userid, 'name', addslashes($name))) { + if ($preference->value === $value) { + return true; + } if (!set_field('user_preferences', 'value', addslashes((string)$value), 'id', $preference->id)) { $return = false; } -- 2.39.5