From a5d96f93077fb8c30caeca91847c7745407b6bd5 Mon Sep 17 00:00:00 2001 From: Sam Hemelryk Date: Mon, 7 Dec 2009 02:43:35 +0000 Subject: [PATCH] question MDL-20910 Fixed buggy conversion of link_to_popup_window --- question/type/questiontype.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/question/type/questiontype.php b/question/type/questiontype.php index 1c63909e9c..7559e1dacd 100644 --- a/question/type/questiontype.php +++ b/question/type/questiontype.php @@ -1128,7 +1128,9 @@ class default_questiontype { if ($state->id == $st->id) { $link = '' . $st->seq_number . ''; } else if (isset($options->questionreviewlink)) { - $link = html_link::make("$options->questionreviewlink?state=$st->id&question=$question->id", $st->seq_number); + $reviewlink = new moodle_url($options->questionreviewlink); + $reviewlink->params(array('state'=>$st->id,'question'=>$question->id)); + $link = html_link::make($reviewlink, $st->seq_number); $link->add_action(new popup_action('click', $link->url, 'reviewquestion', array('height' => 450, 'width' => 650))); $link->title = $strreviewquestion; $link = $OUTPUT->link($link); -- 2.39.5