From b3efb4cfd425d4741de45b3984ec0d26a4290709 Mon Sep 17 00:00:00 2001
From: dongsheng <dongsheng>
Date: Thu, 8 Oct 2009 09:01:34 +0000
Subject: [PATCH] "MDL-13766, delete config if checkbox element is unchecked"

---
 admin/repository.php | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/admin/repository.php b/admin/repository.php
index b26d89d1f0..756faeb8aa 100644
--- a/admin/repository.php
+++ b/admin/repository.php
@@ -70,23 +70,27 @@ if (!empty($edit) || !empty($new)) {
             foreach($configs as $config) {
                 if (!empty($fromform->$config)) {
                     $settings[$config] = $fromform->$config;
+                } else {
+                    // if the config name is not appear in $fromform
+                    // empty this config value
+                    $settings[$config] = '';
                 }
             }
              $instanceoptionnames = repository::static_function($edit, 'get_instance_option_names');
             if (!empty($instanceoptionnames)) {
-                    if (array_key_exists('enablecourseinstances', $fromform)) {
-                        $settings['enablecourseinstances'] = $fromform->enablecourseinstances;
-                    }
-                    else {
-                        $settings['enablecourseinstances'] = 0;
-                    }
-                    if (array_key_exists('enableuserinstances', $fromform)) {
-                        $settings['enableuserinstances'] = $fromform->enableuserinstances;
-                    }
-                    else {
-                        $settings['enableuserinstances'] = 0;
-                    }
+                if (array_key_exists('enablecourseinstances', $fromform)) {
+                    $settings['enablecourseinstances'] = $fromform->enablecourseinstances;
                 }
+                else {
+                    $settings['enablecourseinstances'] = 0;
+                }
+                if (array_key_exists('enableuserinstances', $fromform)) {
+                    $settings['enableuserinstances'] = $fromform->enableuserinstances;
+                }
+                else {
+                    $settings['enableuserinstances'] = 0;
+                }
+            }
             $success = $repositorytype->update_options($settings);
         } else {
             $type = new repository_type($plugin,(array)$fromform);
-- 
2.39.5