From b913b369e87a91412793c532ac577fdb83ef5475 Mon Sep 17 00:00:00 2001
From: moodler <moodler>
Date: Thu, 21 Nov 2002 10:17:08 +0000
Subject: [PATCH] Small bugfix with uploading new user images

---
 user/edit.php | 2 +-
 user/lib.php  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/user/edit.php b/user/edit.php
index c303e34be0..ddd986c97e 100644
--- a/user/edit.php
+++ b/user/edit.php
@@ -49,7 +49,7 @@
         $usernew->firstname = strip_tags($usernew->firstname);
         $usernew->lastname  = strip_tags($usernew->lastname);
 
-        if (find_form_errors($user, $usernew, $err) ) {
+        if (find_form_errors($user, $usernew, $err)) {
             if ($filename = valid_uploaded_file($imagefile)) { 
                 $usernew->picture = save_user_image($user->id, $filename);
             }
diff --git a/user/lib.php b/user/lib.php
index 53623fc122..a008a2434c 100644
--- a/user/lib.php
+++ b/user/lib.php
@@ -88,8 +88,8 @@ function save_user_image($userid, $filename) {
             $badpermissions = true;
         }
     }
-    if (!file_exists("$CFG->dataroot/users/$user->id")) {
-        if (! mkdir("$CFG->dataroot/users/$user->id", 0777)) {
+    if (!file_exists("$CFG->dataroot/users/$userid")) {
+        if (! mkdir("$CFG->dataroot/users/$userid", 0777)) {
             $badpermissions = true;
         }
     }
-- 
2.39.5