From b9c3b8c73446c59a06a9b28bea90c8bae5928738 Mon Sep 17 00:00:00 2001 From: stronk7 Date: Mon, 23 Oct 2006 00:01:57 +0000 Subject: [PATCH] Prevent MSSQL to return from insert_record() before trying to execute the updating of LOBs. Merged from MOODLE_17_STABLE --- lib/dmllib.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/dmllib.php b/lib/dmllib.php index 9a19fbf4db..2907fc658e 100644 --- a/lib/dmllib.php +++ b/lib/dmllib.php @@ -1207,8 +1207,8 @@ function insert_record($table, $dataobject, $returnid=true, $primarykey='id') { } } -/// If a return ID is not needed then just return true now - if (!$returnid) { +/// If a return ID is not needed then just return true now (but not in MSSQL DBs, where we may have some pending tasks) + if (!$returnid && !($CFG->dbtype == 'mssql' || $CFG->dbtype == 'odbc_mssql' || $CFG->dbtype == 'mssql_n')) { return true; } @@ -1218,7 +1218,7 @@ function insert_record($table, $dataobject, $returnid=true, $primarykey='id') { return $dataobject->{$primarykey}; } -/// This only gets triggered with non-Postgres databases +/// This only gets triggered with MySQL and MSQL databases /// however we have some postgres fallback in case we failed /// to find the sequence. $id = $db->Insert_ID(); -- 2.39.5