From ba04999cebdf85b461133449df4b70002255cab1 Mon Sep 17 00:00:00 2001
From: stronk7 <stronk7>
Date: Sat, 30 May 2009 18:51:47 +0000
Subject: [PATCH] MDL-19349 upgrade_plugin_savepoint() added 2 suggestions

---
 lib/upgradelib.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/upgradelib.php b/lib/upgradelib.php
index 99e0332e30..518a86a22f 100644
--- a/lib/upgradelib.php
+++ b/lib/upgradelib.php
@@ -261,6 +261,9 @@ function upgrade_plugin_savepoint($result, $version, $type, $dir, $allowabort=tr
         throw new upgrade_exception("$type/$dir", $version);
     }
 
+    /// TODO: Check that $type is a correct type - based on get_plugin_types()
+    /// TODO: Check that $dir (that perhaps should be named $name) is an existing plugin
+
     $fullname = $type.'_'.$dir;
     $component = $type.'/'.$dir;
 
@@ -1145,4 +1148,4 @@ function core_tables_exist() {
         }
         return true;
     }        
-}
\ No newline at end of file
+}
-- 
2.39.5