From bb63fc3e0c1fc22ec8c6225895c2d112d614a510 Mon Sep 17 00:00:00 2001 From: mjollnir_ Date: Tue, 29 Jul 2008 12:10:14 +0000 Subject: [PATCH] MDL-15834 portfolio supported_formats doesn't need to be abstract --- lib/portfoliolib.php | 8 ++++++-- mod/assignment/lib.php | 5 ----- mod/forum/lib.php | 4 ---- mod/resource/lib.php | 4 ---- portfolio/type/boxnet/lib.php | 4 ---- portfolio/type/download/lib.php | 5 ----- 6 files changed, 6 insertions(+), 24 deletions(-) diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php index 84863c1fb1..d5437e80f7 100644 --- a/lib/portfoliolib.php +++ b/lib/portfoliolib.php @@ -705,7 +705,9 @@ abstract class portfolio_caller_base { * * @return array list of formats */ - public abstract static function supported_formats(); + public static function supported_formats() { + return array(PORTFOLIO_FORMAT_FILE); + } /** * this is the "return to where you were" url @@ -810,7 +812,9 @@ abstract class portfolio_plugin_base { * * @return array list of formats */ - public abstract static function supported_formats(); + public static function supported_formats() { + return array(PORTFOLIO_FORMAT_FILE); + } /** diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php index c1dae2afb4..6e81b15ba2 100644 --- a/mod/assignment/lib.php +++ b/mod/assignment/lib.php @@ -3162,11 +3162,6 @@ class assignment_portfolio_caller extends portfolio_module_caller_base { return backup_copy_file($filearea, $tempdir); } - public static function supported_formats() { - return array(PORTFOLIO_FORMAT_FILE); - } - - public function expected_time() { return PORTFOLIO_TIME_MODERATE; // @TODO check uploaded file size } diff --git a/mod/forum/lib.php b/mod/forum/lib.php index 292ed5b397..c238ed3910 100644 --- a/mod/forum/lib.php +++ b/mod/forum/lib.php @@ -7069,10 +7069,6 @@ class forum_portfolio_caller extends portfolio_module_caller_base { // @todo see MDL-15758 } - static function supported_formats() { - return array(PORTFOLIO_FORMAT_FILE); - } - function expected_time() { // @todo check for attachment size return PORTFOLIO_TIME_LOW; diff --git a/mod/resource/lib.php b/mod/resource/lib.php index b5e8c93851..02d2dc71b2 100644 --- a/mod/resource/lib.php +++ b/mod/resource/lib.php @@ -738,10 +738,6 @@ class resource_portfolio_caller extends portfolio_module_caller_base { return $this->resource->portfolio_prepare_package($tempdir); } - public static function supported_formats() { - return array(PORTFOLIO_FORMAT_FILE); - } - public function check_permissions() { return true; } diff --git a/portfolio/type/boxnet/lib.php b/portfolio/type/boxnet/lib.php index 7eca2b4390..ebcf548258 100644 --- a/portfolio/type/boxnet/lib.php +++ b/portfolio/type/boxnet/lib.php @@ -10,10 +10,6 @@ class portfolio_plugin_boxnet extends portfolio_plugin_base { private $workdir; private $folders; - public static function supported_formats() { - return array(PORTFOLIO_FORMAT_FILE); - } - public function prepare_package($tempdir) { $this->workdir = $tempdir; return true; // don't do anything else for this plugin, we want to send all files as they are. diff --git a/portfolio/type/download/lib.php b/portfolio/type/download/lib.php index 7775d75a64..e37c1aa9e4 100644 --- a/portfolio/type/download/lib.php +++ b/portfolio/type/download/lib.php @@ -7,11 +7,6 @@ class portfolio_plugin_download extends portfolio_plugin_base { protected $zipfile; protected $exportconfig; - public static function supported_formats() { - return array(PORTFOLIO_FORMAT_FILE); - // @todo more later, like moodle backup for example - } - public static function allows_multiple() { return false; } -- 2.39.5