From bbf9b1624dc6c26148cc1466b7c72150a7535f22 Mon Sep 17 00:00:00 2001 From: moodler Date: Sat, 17 May 2003 06:10:20 +0000 Subject: [PATCH] Improved get_site_users a bit for efficiency --- lib/datalib.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/datalib.php b/lib/datalib.php index da231a4971..075a4df764 100644 --- a/lib/datalib.php +++ b/lib/datalib.php @@ -920,12 +920,14 @@ function get_site_users($sort="u.lastaccess DESC") { global $CFG; - return get_records_sql("SELECT u.* FROM {$CFG->prefix}user u, - {$CFG->prefix}user_students s, - {$CFG->prefix}user_teachers t - WHERE s.userid = u.id - OR t.userid = u.id - GROUP BY u.id ORDER BY $sort"); + return get_records_sql("SELECT u.id, u.username, u.firstname, u.lastname, u.maildisplay, + u.email, u.city, u.country, u.lastaccess, u.lastlogin, u.picture + FROM {$CFG->prefix}user u, + {$CFG->prefix}user_students s, + {$CFG->prefix}user_teachers t + WHERE s.userid = u.id + OR t.userid = u.id + GROUP BY u.id ORDER BY $sort"); } -- 2.39.5