From c267a2886acc4e4efd3a41545baabcb726914fe1 Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Mon, 26 Nov 2007 17:45:56 +0000
Subject: [PATCH] MDL-12350 do not set parent cat when updating; merged from
 MOODLE_19_STABLE

---
 grade/edit/tree/item.php        | 10 +++++-----
 grade/edit/tree/outcomeitem.php |  4 ----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/grade/edit/tree/item.php b/grade/edit/tree/item.php
index 673c924115..6db3b6c5a9 100644
--- a/grade/edit/tree/item.php
+++ b/grade/edit/tree/item.php
@@ -125,15 +125,15 @@ if ($data = $mform->get_data(false)) {
         $grade_item->itemtype = 'manual'; // all new items to be manual only
         $grade_item->insert();
 
+        // set parent if needed
+        if (isset($data->parentcategory)) {
+            $grade_item->set_parent($data->parentcategory, 'gradebook');
+        }
+
     } else {
         $grade_item->update();
     }
 
-    // set parent if needed
-    if (isset($data->parentcategory)) {
-        $grade_item->set_parent($data->parentcategory, 'gradebook');
-    }
-
     // update hiding flag
     if ($hiddenuntil) {
         $grade_item->set_hidden($hiddenuntil, false);
diff --git a/grade/edit/tree/outcomeitem.php b/grade/edit/tree/outcomeitem.php
index bc6334feab..c6df539802 100644
--- a/grade/edit/tree/outcomeitem.php
+++ b/grade/edit/tree/outcomeitem.php
@@ -186,10 +186,6 @@ if ($data = $mform->get_data(false)) {
 
     } else {
         $grade_item->update();
-        // set parent if needed
-        if (isset($data->parentcategory)) {
-            $grade_item->set_parent($data->parentcategory, 'gradebook');
-        }
     }
 
     // update hiding flag
-- 
2.39.5