From c5e4f81d9adb697d6a3e5a5d1fda1f4a08f383cc Mon Sep 17 00:00:00 2001 From: samhemelryk Date: Thu, 15 Oct 2009 02:19:51 +0000 Subject: [PATCH] admin MDL-19787 Added PAGE->set_url calls and removed $Id tags --- admin/auth.php | 2 ++ admin/dbperformance.php | 3 ++- admin/mnet/delete.html | 12 +----------- admin/mnet/delete.php | 12 +++++++++++- admin/report/courseoverview/reportsgraph.php | 5 +++-- admin/roles/explain.php | 4 +++- admin/timezone.php | 3 ++- 7 files changed, 24 insertions(+), 17 deletions(-) diff --git a/admin/auth.php b/admin/auth.php index fbd9a7cd46..fe3d610827 100644 --- a/admin/auth.php +++ b/admin/auth.php @@ -16,6 +16,8 @@ require_capability('moodle/site:config', get_context_instance(CONTEXT_SYSTEM)); $returnurl = "$CFG->wwwroot/$CFG->admin/settings.php?section=manageauths"; +$PAGE->set_url($returnurl); + $action = optional_param('action', '', PARAM_ACTION); $auth = optional_param('auth', '', PARAM_SAFEDIR); diff --git a/admin/dbperformance.php b/admin/dbperformance.php index 69364f96f3..f5f597b622 100644 --- a/admin/dbperformance.php +++ b/admin/dbperformance.php @@ -1,4 +1,4 @@ -set_url(new moodle_url($CFG->wwwroot.'/admin/dbperformance.php')); $PAGE->navbar->add($stradministration, new moodle_url($CFG->wwwroot.'/admin/index.php')); $PAGE->navbar->add($strdatabaseperformance); $PAGE->set_title("$site->shortname: $strdatabaseperformance"); diff --git a/admin/mnet/delete.html b/admin/mnet/delete.html index 2729e85989..234d78053f 100644 --- a/admin/mnet/delete.html +++ b/admin/mnet/delete.html @@ -1,12 +1,5 @@ navbar->add($stradministration, new moodle_url($CFG->wwwroot.'/'.$CFG->admin.'/index.php')); -$PAGE->navbar->add(get_string('mnetsettings', 'mnet'), new moodle_url($CFG->wwwroot.'/'.$CFG->admin.'/mnet/index.php')); -$PAGE->navbar->add(get_string('deletehost', 'mnet')); - -$PAGE->set_title("$site->shortname: $strmnetsettings"); -$PAGE->set_heading($site->fullname); -echo $OUTPUT->header(); -echo $OUTPUT->heading(get_string('mnetsettings', 'mnet')); +// Please see delete.php for PAGE and OUTPUT calls that preceed including this file ?>
@@ -50,6 +43,3 @@ echo $OUTPUT->heading(get_string('mnetsettings', 'mnet'));
-footer(); -?> diff --git a/admin/mnet/delete.php b/admin/mnet/delete.php index 15781bdf72..0b8a466c32 100644 --- a/admin/mnet/delete.php +++ b/admin/mnet/delete.php @@ -1,4 +1,4 @@ -dirroot.'/mnet/lib.php'); @@ -38,7 +38,17 @@ if ($live_users > 0) { $warn[] = get_string('usersareonline', 'mnet', $live_users); } + $PAGE->set_url(new moodle_url($CFG->wwwroot.'/admin/mnet/delete.php')); + $PAGE->navbar->add($stradministration, new moodle_url($CFG->wwwroot.'/'.$CFG->admin.'/index.php')); + $PAGE->navbar->add(get_string('mnetsettings', 'mnet'), new moodle_url($CFG->wwwroot.'/'.$CFG->admin.'/mnet/index.php')); + $PAGE->navbar->add(get_string('deletehost', 'mnet')); + + $PAGE->set_title("$site->shortname: $strmnetsettings"); + $PAGE->set_heading($site->fullname); + echo $OUTPUT->header(); + echo $OUTPUT->heading(get_string('mnetsettings', 'mnet')); include('delete.html'); + echo $OUTPUT->footer(); } elseif ('delete' == $step) { $mnet_peer = new mnet_peer(); $mnet_peer->set_id($hostid); diff --git a/admin/report/courseoverview/reportsgraph.php b/admin/report/courseoverview/reportsgraph.php index db3e71a2a9..b6b4a6de79 100644 --- a/admin/report/courseoverview/reportsgraph.php +++ b/admin/report/courseoverview/reportsgraph.php @@ -1,4 +1,4 @@ -dirroot.'/lib/statslib.php'); @@ -30,7 +30,8 @@ $courses = $DB->get_records_sql($sql, $param->$params, 0, $numcourses); if (empty($courses)) { - print_error('statsnodata', 'error', $CFG->wwwroot.'/'.$CFG->admin.'/report/course/index.php'); + $PAGE->set_url(new moodle_url($CFG->wwwroot.'/'.$CFG->admin.'/report/courseoverview/index.php')); + print_error('statsnodata', 'error', $PAGE->url->out()); } diff --git a/admin/roles/explain.php b/admin/roles/explain.php index a4b6c0a6c3..d904be28e7 100755 --- a/admin/roles/explain.php +++ b/admin/roles/explain.php @@ -1,4 +1,4 @@ -set_url(new moodle_url($CFG->wwwroot.'/admin/roles/explain.php', array('user'=>$userid, 'contextid'=>$contextid, 'capability'=>$capability))); + // Get the context and its parents. $context = get_context_instance_by_id($contextid); if (!$context) { diff --git a/admin/timezone.php b/admin/timezone.php index 576f4e0f52..e8b21c80a3 100644 --- a/admin/timezone.php +++ b/admin/timezone.php @@ -1,4 +1,4 @@ -set_url(new moodle_url($CFG->wwwroot.'/admin/timezone.php')); $PAGE->set_title($strtimezone); $PAGE->set_heading($strtimezone); $PAGE->navbar->add($strtimezone); -- 2.39.5