From cc28a5b5600974db48a819d0598da4af652f7a3a Mon Sep 17 00:00:00 2001 From: moodler Date: Tue, 23 Nov 2004 02:41:45 +0000 Subject: [PATCH] Just a code tidy up --- mod/quiz/preview.php | 215 +++++++++++++++++++++---------------------- 1 file changed, 107 insertions(+), 108 deletions(-) diff --git a/mod/quiz/preview.php b/mod/quiz/preview.php index 32354025f4..4edb017e78 100644 --- a/mod/quiz/preview.php +++ b/mod/quiz/preview.php @@ -1,139 +1,138 @@ -dirroot/files/mimetypes.php"); - optional_variable($qtype); - optional_variable($category); +optional_variable($id); // question id +optional_variable($qtype); +optional_variable($category); - if ($id) { - if (! $question = get_record("quiz_questions", "id", $id)) { - error("This question doesn't exist"); - } - if (!empty($category)) { - $question->category = $category; - } - if (! $category = get_record("quiz_categories", "id", $question->category)) { - error("This question doesn't belong to a valid category!"); - } - if (! $course = get_record("course", "id", $category->course)) { - error("This question category doesn't belong to a valid course!"); - } +if ($id) { + if (! $question = get_record("quiz_questions", "id", $id)) { + error("This question doesn't exist"); + } + if (!empty($category)) { + $question->category = $category; + } + if (! $category = get_record("quiz_categories", "id", $question->category)) { + error("This question doesn't belong to a valid category!"); + } + if (! $course = get_record("course", "id", $category->course)) { + error("This question category doesn't belong to a valid course!"); + } - $qtype = $question->qtype; + $qtype = $question->qtype; - } else if ($category) { - if (! $category = get_record("quiz_categories", "id", $category)) { - error("This wasn't a valid category!"); - } - if (! $course = get_record("course", "id", $category->course)) { - error("This category doesn't belong to a valid course!"); - } +} else if ($category) { + if (! $category = get_record("quiz_categories", "id", $category)) { + error("This wasn't a valid category!"); + } + if (! $course = get_record("course", "id", $category->course)) { + error("This category doesn't belong to a valid course!"); + } - $question->category = $category->id; - $question->qtype = $qtype; + $question->category = $category->id; + $question->qtype = $qtype; - } else { - error("Must specify question id or category"); - } +} else { + error("Must specify question id or category"); +} - if (empty($qtype)) { - error("No question type was specified!"); - } else if (!isset($QUIZ_QTYPES[$qtype])) { - error("Could not find question type: '$qtype'"); - } +if (empty($qtype)) { + error("No question type was specified!"); +} else if (!isset($QUIZ_QTYPES[$qtype])) { + error("Could not find question type: '$qtype'"); +} - require_login($course->id); +require_login($course->id); - if (!isteacheredit($course->id)) { - error("You can't modify these questions!"); - } +if (!isteacheredit($course->id)) { + error("You can't modify these questions!"); +} - $strquizzes = get_string('modulenameplural', 'quiz'); - $streditingquiz = get_string(isset($SESSION->modform->instance) ? "editingquiz" : "editquestions", "quiz"); - $streditingquestion = get_string("editingquestion", "quiz"); +$strquizzes = get_string('modulenameplural', 'quiz'); +$streditingquiz = get_string(isset($SESSION->modform->instance) ? "editingquiz" : "editquestions", "quiz"); +$streditingquestion = get_string("editingquestion", "quiz"); - print_header(); - print_heading(get_string("previewquestion","quiz")); +print_header(); +print_heading(get_string("previewquestion","quiz")); - if (empty($question->id)) { - $question->id = ""; - } - if (empty($question->name)) { - $question->name = ""; - } - if (empty($question->questiontext)) { - $question->questiontext = ""; - } - if (empty($question->image)) { - $question->image = ""; - } +if (empty($question->id)) { + $question->id = ""; +} +if (empty($question->name)) { + $question->name = ""; +} +if (empty($question->questiontext)) { + $question->questiontext = ""; +} +if (empty($question->image)) { + $question->image = ""; +} - if ($results && isset($results->details[$question->id])) { - $details = $results->details[$question->id]; - } else { - $details = false; - } +if ($results && isset($results->details[$question->id])) { + $details = $results->details[$question->id]; +} else { + $details = false; +} - if($rawanswers = data_submitted()) { - $rawanswers = (array)$rawanswers; +if ($rawanswers = data_submitted()) { + $rawanswers = (array)$rawanswers; - $answers = array(); - $feedbacks = array(); - $qids = array(); - $fraction = 0; + $answers = array(); + $feedbacks = array(); + $qids = array(); + $fraction = 0; - foreach ($rawanswers as $key => $value) { // Parse input for question->response + foreach ($rawanswers as $key => $value) { // Parse input for question->response $postedId = quiz_extract_posted_id($key); if ($id == $postedId) $question->response[$key] = trim($value); - }//end for each rowanswers + } - print_simple_box_start("center", "90%"); + print_simple_box_start("center", "90%"); - //simulate quiz only for quiestion previews - class FakeQuiz { + //simulate quiz only for quiestion previews + class FakeQuiz { var $correctanswers; var $feedback; var $grade; - function FakeQuiz() - { - $this->correctanswers = 1; - $this->feedback = 1; - $this->grade = 1; + function FakeQuiz() { + $this->correctanswers = 1; + $this->feedback = 1; + $this->grade = 1; } - }; - - $question->maxgrade = 1; //this shouldn't be like that - $resultdetails = $QUIZ_QTYPES[$question->qtype]->grade_response($question, quiz_qtype_nameprefix($question)); - $quiz = new FakeQuiz(); - - $QUIZ_QTYPES[$question->qtype]->print_question - (1, $quiz, $question, true, $resultdetails); - - print_simple_box_end(); - echo "

\n"; - echo "

\n"; - - } else {//show question list - echo "
\n"; - echo "\n"; - - print_simple_box_start("center", "90%"); - $nextquestionnumber = $QUIZ_QTYPES[$question->qtype]->print_question - ($nextquestionnumber, $quiz, $question, $readonly, $resultdetails); - print_simple_box_end(); - - echo "
"; - echo "
"; - echo "\n"; - echo ""; - echo "
"; - echo "
"; } + $question->maxgrade = 1; //this shouldn't be like that + $resultdetails = $QUIZ_QTYPES[$question->qtype]->grade_response($question, quiz_qtype_nameprefix($question)); + $quiz = new FakeQuiz(); + + $QUIZ_QTYPES[$question->qtype]->print_question(1, $quiz, $question, true, $resultdetails); + + print_simple_box_end(); + echo "

\n"; + echo "

\n"; + +} else { //show question list + echo "
\n"; + echo "\n"; + + print_simple_box_start("center", "90%"); + $nextquestionnumber = $QUIZ_QTYPES[$question->qtype]->print_question($nextquestionnumber, $quiz, + $question, $readonly, $resultdetails); + print_simple_box_end(); + + echo "
"; + echo "
"; + echo "\n"; + echo ""; + echo "
"; + echo "
"; +} + ?> -- 2.39.5