From cddbd5d5feb0ebe3efb408f6d993496621cf2440 Mon Sep 17 00:00:00 2001 From: nicolasconnault Date: Thu, 22 Mar 2007 07:16:57 +0000 Subject: [PATCH] MDL-8807: The icon's title attribute wasn't being updated along with its img.src MDL-8997: A couple of typos: groupseparate instead of groupsseparate etc... --- course/lib.php | 4 ++-- lib/ajax/section_classes.js | 17 +++++++++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/course/lib.php b/course/lib.php index 8bcd7a358b..af2fc1caa9 100644 --- a/course/lib.php +++ b/course/lib.php @@ -2258,12 +2258,12 @@ function make_editing_buttons($mod, $absolute=false, $moveselect=true, $indent=- if ($mod->groupmode !== false) { if ($mod->groupmode == SEPARATEGROUPS) { $grouptitle = $str->groupsseparate; - $groupclass = 'editing_groupseparate'; + $groupclass = 'editing_groupsseparate'; $groupimage = $CFG->pixpath.'/t/groups.gif'; $grouplink = $path.'/mod.php?id='.$mod->id.'&groupmode=0&sesskey='.$sesskey; } else if ($mod->groupmode == VISIBLEGROUPS) { $grouptitle = $str->groupsvisible; - $groupclass = 'editing_groupvisible'; + $groupclass = 'editing_groupsvisible'; $groupimage = $CFG->pixpath.'/t/groupv.gif'; $grouplink = $path.'/mod.php?id='.$mod->id.'&groupmode=1&sesskey='.$sesskey; } else { diff --git a/lib/ajax/section_classes.js b/lib/ajax/section_classes.js index 0990c007c1..c4483f5f70 100755 --- a/lib/ajax/section_classes.js +++ b/lib/ajax/section_classes.js @@ -760,6 +760,23 @@ resource_class.prototype.toggle_groupmode = function() { if (this.groupmode > 2) { this.groupmode = 0; } + + var newtitle = this.groupButton.getElementsByTagName('img')[0].title; + + switch (this.groupmode) { + case 0: + newtitle = main.portal.strings['groupsnone']+' ('+main.portal.strings['clicktochange']+')'; + break; + case 1: + newtitle = main.portal.strings['groupsseparate']+' ('+main.portal.strings['clicktochange']+')'; + break; + case 2: + newtitle = main.portal.strings['groupsvisible']+' ('+main.portal.strings['clicktochange']+')'; + break; + } + + this.groupButton.getElementsByTagName('img')[0].title = newtitle; + this.groupButton.getElementsByTagName('img')[0].src = main.portal.strings['pixpath']+this.groupImages[this.groupmode]; main.connect('POST', 'class=resource&field=groupmode', null, 'value='+this.groupmode+'&id='+this.id); } -- 2.39.5