From ce11763a23bcb7a596692428880bc61fd1746ddc Mon Sep 17 00:00:00 2001 From: stronk7 Date: Thu, 30 Jul 2009 13:40:59 +0000 Subject: [PATCH] MDL-19969 standarising plugin names - prevent dupes in case record is already there --- lib/db/upgrade.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php index 2976fd8aea..b7a4c5b544 100644 --- a/lib/db/upgrade.php +++ b/lib/db/upgrade.php @@ -2208,8 +2208,9 @@ WHERE gradeitemid IS NOT NULL AND grademax IS NOT NULL"); // standardizing plugin names if ($configs = $DB->get_records_select('config_plugins', "plugin LIKE 'quizreport_%'")) { foreach ($configs as $config) { + $result = $result && unset_config($config->name, $config->plugin); /// unset old config $config->plugin = str_replace('quizreport_', 'quiz_', $config->plugin); - $DB->update_record('config_plugins', $config); + $result = $result && set_config($config->name, $config->value, $config->plugin); /// set new config } } unset($configs); @@ -2220,8 +2221,9 @@ WHERE gradeitemid IS NOT NULL AND grademax IS NOT NULL"); // standardizing plugin names if ($configs = $DB->get_records_select('config_plugins', "plugin LIKE 'assignment_type_%'")) { foreach ($configs as $config) { + $result = $result && unset_config($config->name, $config->plugin); /// unset old config $config->plugin = str_replace('assignment_type_', 'assignment_', $config->plugin); - $DB->update_record('config_plugins', $config); + $result = $result && set_config($config->name, $config->value, $config->plugin); /// set new config } } unset($configs); -- 2.39.5