From dcb8916f2d26985a0e254a94bba6455782542310 Mon Sep 17 00:00:00 2001
From: stronk7 <stronk7>
Date: Sun, 3 Sep 2006 22:32:14 +0000
Subject: [PATCH] notice() should be allowed at install/upgrade. It stops the
 whole process without need to do it. Changed to notify().

Thanks to one "orphan" forum in moodle.org (234) we detected this.
---
 mod/forum/lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
index 3570396c9e..13bd5c4942 100644
--- a/mod/forum/lib.php
+++ b/mod/forum/lib.php
@@ -4258,8 +4258,8 @@ function forum_convert_to_roles($forum, $forummodid, $studentroles=array(), $gue
         if (empty($cmid)) {
             // We were not given the course_module id. Try to find it.
             if (!$cm = get_coursemodule_from_instance('forum', $forum->id)) {
-                notice('Could not get the course module for the forum');
-                continue;
+                notify('Could not get the course module for the forum');
+                return false;
             } else {
                 $cmid = $cm->id;
             }
-- 
2.39.5