From dd2a21da76803af52481acb5c4613afccb600145 Mon Sep 17 00:00:00 2001 From: vyshane Date: Mon, 15 Jan 2007 07:59:28 +0000 Subject: [PATCH] Fixes for MDL-7861. --- admin/report/log/index.php | 10 ++++++---- course/report/log/lib.php | 14 ++++++++------ 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/admin/report/log/index.php b/admin/report/log/index.php index 9476132641..d89c533812 100644 --- a/admin/report/log/index.php +++ b/admin/report/log/index.php @@ -21,11 +21,13 @@ echo '
'; print_heading(get_string('chooselivelogs') .':'); - echo '

'; - link_to_popup_window('/course/report/log/live.php?id='. $course->id,'livelog', get_string('livelogs'), 500, 800); - echo '

'; + $heading = link_to_popup_window('/course/report/log/live.php?id='. $course->id, + 'livelog', get_string('livelogs'), + 500, 800, '', 'none', true); + + print_heading($heading, 'center', 3); admin_externalpage_print_footer($adminroot); -?> +?> \ No newline at end of file diff --git a/course/report/log/lib.php b/course/report/log/lib.php index 4bbebde8f5..17b267c22b 100644 --- a/course/report/log/lib.php +++ b/course/report/log/lib.php @@ -84,10 +84,11 @@ function print_mnet_log_selector_form($hostid, $course, $selecteduser=0, $select h.id = l.hostid order by h.name"; - $hosts = get_records_sql($sql); - foreach($hosts as $host) { - $hostarray[$host->id] = $host->name; + if ($hosts = get_records_sql($sql)) { + foreach($hosts as $host) { + $hostarray[$host->id] = $host->name; + } } $hostarray[$CFG->mnet_localhost_id] = $SITE->fullname; @@ -212,8 +213,8 @@ function print_mnet_log_selector_form($hostid, $course, $selecteduser=0, $select } $cid = empty($course->id)? '1' : $course->id; - echo "
\n"; - echo "
wwwroot/course/report/log/index.php\" method=\"get\">\n"; + echo "wwwroot/course/report/log/index.php\" method=\"get\">\n"; + echo "
\n"; echo "\n"; echo "\n"; echo "\n"; @@ -261,6 +262,7 @@ function print_mnet_log_selector_form($hostid, $course, $selecteduser=0, $select print_string('logtoomanyusers','moodle',$a); } choose_from_menu ($dates, "date", $selecteddate, get_string("alldays")); + echo '
'; choose_from_menu ($activities, "modid", $selectedactivity, get_string("allactivities"), "", ""); choose_from_menu ($actions, 'modaction', $modaction, get_string("allactions")); @@ -275,8 +277,8 @@ function print_mnet_log_selector_form($hostid, $course, $selecteduser=0, $select */ choose_from_menu ($logformats, 'logformat', $logformat, false); echo ''; + echo '
'; echo "
"; - echo "
"; } function print_log_selector_form($course, $selecteduser=0, $selecteddate='today', -- 2.39.5