From e24a1f364af04f4a2af0a881e9a911e0fc1a0113 Mon Sep 17 00:00:00 2001 From: skodak Date: Thu, 9 Nov 2006 21:58:12 +0000 Subject: [PATCH] coding style fixes MDL-6954 --- course/request.php | 8 +++----- course/request_form.php | 43 +++++++++++++++++++++-------------------- 2 files changed, 25 insertions(+), 26 deletions(-) diff --git a/course/request.php b/course/request.php index 38524a2924..a01f5b95c4 100644 --- a/course/request.php +++ b/course/request.php @@ -19,9 +19,9 @@ $requestform = new course_request_form('request.php'); $strtitle = get_string('courserequest'); - print_header($strtitle,$strtitle,$strtitle, $requestform->focus()); + print_header($strtitle, $strtitle, $strtitle, $requestform->focus()); - print_simple_box_start("center"); + print_simple_box_start('center'); print_string('courserequestintro'); print_simple_box_end(); @@ -30,7 +30,7 @@ $data->requester = $USER->id; - if (insert_record('course_request',$data)) { + if (insert_record('course_request', $data)) { notice(get_string('courserequestsuccess')); } else { notice(get_string('courserequestfailed')); @@ -38,7 +38,6 @@ print_footer(); exit; - } @@ -49,5 +48,4 @@ exit; - ?> \ No newline at end of file diff --git a/course/request_form.php b/course/request_form.php index bc7be36329..ff2429b08b 100644 --- a/course/request_form.php +++ b/course/request_form.php @@ -1,44 +1,46 @@ -libdir.'/formslib.php'; + class course_request_form extends moodleform { function definition() { - $mform =& $this->_form; + $mform =& $this->_form; - $mform->addElement('text','fullname',get_string("fullname"),'maxlength="254" size="50"'); - $mform->addRule('fullname',get_string('missingshortname'),'required', null, 'client'); + $mform->addElement('text', 'fullname', get_string('fullname'), 'maxlength="254" size="50"'); + $mform->addRule('fullname', get_string('missingshortname'), 'required', null, 'client'); $mform->setType('fullname', PARAM_TEXT); - $mform->addElement('text','shortname',get_string("shortname"),'maxlength="15" size="10"'); - $mform->addRule('shortname',get_string('missingfullname'),'required', null, 'client'); + $mform->addElement('text', 'shortname', get_string('shortname'), 'maxlength="15" size="10"'); + $mform->addRule('shortname', get_string('missingfullname'), 'required', null, 'client'); $mform->setType('shortname', PARAM_TEXT); - $mform->addElement('htmleditor','summary',get_string("summary"),array('rows'=>'15','cols'=>'50')); - $mform->addRule('summary',get_string('missingsummary'),'required', null, 'client'); + $mform->addElement('htmleditor', 'summary', get_string('summary'), array('rows'=>'15', 'cols'=>'50')); + $mform->addRule('summary', get_string('missingsummary'), 'required', null, 'client'); $mform->setType('summary', PARAM_RAW); - $mform->addElement('textarea','reason',get_string("courserequestreason"),array('rows'=>'15','cols'=>'50')); - $mform->addRule('reason',get_string('missingreqreason'),'required', null, 'client'); + $mform->addElement('textarea', 'reason', get_string('courserequestreason'), array('rows'=>'15', 'cols'=>'50')); + $mform->addRule('reason', get_string('missingreqreason'), 'required', null, 'client'); $mform->setType('reason', PARAM_TEXT); - $mform->addElement('text','password',get_string("enrolmentkey"),'size="25"'); + $mform->addElement('text', 'password', get_string('enrolmentkey'), 'size="25"'); $mform->setType('password', PARAM_RAW); - $mform->addElement('submit','',get_string("savechanges")); + $mform->addElement('submit', '', get_string('savechanges')); } function validation($data) { - $errors=array(); + $errors = array(); $foundcourses = null; $foundreqcourses = null; if (!empty($data['shortname'])) { - $foundcourses = get_records("course", "shortname", $data['shortname']); - $foundreqcourses = get_records("course_request", "shortname", $data['shortname']); + $foundcourses = get_records('course', 'shortname', $data['shortname']); + $foundreqcourses = get_records('course_request', 'shortname', $data['shortname']); } if (!empty($foundreqcourses)) { if (!empty($foundcourses)) { - $foundcourses = array_merge($foundcourses,$foundreqcourses); + $foundcourses = array_merge($foundcourses, $foundreqcourses); } else { $foundcourses = $foundreqcourses; } @@ -57,20 +59,19 @@ class course_request_form extends moodleform { } $foundcoursenamestring = addslashes(implode(',', $foundcoursenames)); - $errors["shortname"] = get_string("shortnametaken", "", $foundcoursenamestring); + $errors['shortname'] = get_string('shortnametaken', '', $foundcoursenamestring); if (!empty($pending)) { - $errors["shortname"] .= get_string('starpending'); + $errors['shortname'] .= get_string('starpending'); } } } - if (0==count($errors)){ + if (0 == count($errors)){ return true; - }else { + } else { return $errors; } } - } ?> \ No newline at end of file -- 2.39.5