From e38204d1757b1c3af0b438a4d5e9ca4ad6d7abbf Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Wed, 18 Oct 2006 21:34:06 +0000
Subject: [PATCH] fixed access check when editting notes in advanced upload
 assignment type; merged from MOODLE_17_STABLE

---
 .../type/upload/assignment.class.php          | 20 +++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/mod/assignment/type/upload/assignment.class.php b/mod/assignment/type/upload/assignment.class.php
index ccc670e4f2..21b3c86c5a 100644
--- a/mod/assignment/type/upload/assignment.class.php
+++ b/mod/assignment/type/upload/assignment.class.php
@@ -436,6 +436,20 @@ class assignment_upload extends assignment_base {
 
         $returnurl = 'view.php?id='.$this->cm->id;
 
+        if ($submission = $this->get_submission($USER->id)) {
+            $defaulttext = $submission->data1;
+        } else {
+            $defaulttext = '';
+        }
+
+        if (!$this->can_update_notes($submission)) {
+            $this->view_header(get_string('upload'));
+            notify(get_string('uploaderror', 'assignment'));
+            print_continue($returnurl);
+            $this->view_footer();
+            die;
+        }
+
         if (data_submitted() and $action == 'savenotes') {
             $text = required_param('text', PARAM_RAW); // to be cleaned before display
             $submission = $this->get_submission($USER->id, true); // get or create submission
@@ -457,12 +471,6 @@ class assignment_upload extends assignment_base {
         }
 
         /// show notes edit form
-        if ($submission = $this->get_submission($USER->id)) {
-            $defaulttext = $submission->data1;
-        } else {
-            $defaulttext = '';
-        }
-
         $this->view_header(get_string('notes', 'assignment'));
         print_heading(get_string('notes', 'assignment'), 'center');
 
-- 
2.39.5