From e4c5abdc562d11941f26da9d9ea11e4aa3f6f03d Mon Sep 17 00:00:00 2001
From: nicolasconnault <nicolasconnault>
Date: Thu, 13 Aug 2009 01:43:57 +0000
Subject: [PATCH] MDL-19808 Fixed dropdown for moving forum discussions

---
 lib/outputcomponents.php | 8 ++++++--
 mod/forum/discuss.php    | 4 ++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/outputcomponents.php b/lib/outputcomponents.php
index 8953056ec9..0913466a72 100644
--- a/lib/outputcomponents.php
+++ b/lib/outputcomponents.php
@@ -555,7 +555,10 @@ class html_select extends labelled_html_component {
     public function override_option_values($options) {
         global $PAGE;
 
+        $originalcount = count($options);
         $this->initialise_options();
+        $newcount = count($this->options);
+        $first = true;
 
         reset($options);
 
@@ -572,15 +575,16 @@ class html_select extends labelled_html_component {
                     }
                 }
                 next($options);
-            } else if ($optgroup instanceof html_select_option) {
-                next($options);
+            } else if ($optgroup instanceof html_select_option && !($first && $originalcount < $newcount)) {
                 $this->options[$optkey]->value = key($options);
                 $optionurl = new moodle_url(key($options));
 
                 if ($optionurl->compare($PAGE->url, URL_MATCH_PARAMS)) {
                     $this->options[$optkey]->selected = 'selected';
                 }
+                next($options);
             }
+            $first = false;
         }
     }
 
diff --git a/mod/forum/discuss.php b/mod/forum/discuss.php
index 8c3fb7c853..4604edcdfe 100644
--- a/mod/forum/discuss.php
+++ b/mod/forum/discuss.php
@@ -92,7 +92,7 @@
             print_error('cannotpurgecachedrss', 'forum', $return);
         }
 
-        redirect($return.'&amp;moved=-1&amp;sesskey='.sesskey());
+        redirect($return.'&moved=-1&sesskey='.sesskey());
     }
 
     $logparameters = "d=$discussion->id";
@@ -206,7 +206,7 @@
                 }
                 $section = $forumcm->sectionnum;
                 if ($forumcm->instance != $forum->id) {
-                    $url = "discuss.php?d=$discussion->id&move=$forumcm->instance&sesskey=".sesskey();
+                    $url = $CFG->wwwroot . "/mod/forum/discuss.php?d=$discussion->id&move=$forumcm->instance&sesskey=".sesskey();
                     $forummenu[$url] = format_string($forumcm->name);
                 }
             }
-- 
2.39.5