From e5245c73a5e5f7b9e8c5b97a3fed6393522292f9 Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Sun, 7 Oct 2007 14:08:37 +0000
Subject: [PATCH] MDL-11448 FirstClass Authentication does not hold settings
 and has cosmetic and info leakage issues, patch by Dan Trockman

---
 auth/fc/auth.php      | 6 +++---
 auth/fc/fcFPP.php     | 2 +-
 lang/en_utf8/auth.php | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/auth/fc/auth.php b/auth/fc/auth.php
index 45049ad9f2..9ef341b352 100644
--- a/auth/fc/auth.php
+++ b/auth/fc/auth.php
@@ -88,7 +88,7 @@ class auth_plugin_fc extends auth_plugin_base {
 
         $userinfo = array();
 
-        $fpp = new fcFPP($this->config->host, $this->config->port);
+        $fpp = new fcFPP($this->config->host, $this->config->fppport);
         if ($fpp->open()) {
             if ($fpp->login($this->config->userid, $this->config->passwd)) {
                 $userinfo['firstname']   = $fpp->getUserInfo($username,"1202");
@@ -121,7 +121,7 @@ class auth_plugin_fc extends auth_plugin_base {
 
         $fcgroups = array();
 
-        $fpp = new fcFPP($this->config->host, $this->config->port);
+        $fpp = new fcFPP($this->config->host, $this->config->fppport);
         if ($fpp->open()) {
             if ($fpp->login($this->config->userid, $this->config->passwd)) {
                 $fcgroups = $fpp->getGroups($username);
@@ -224,7 +224,7 @@ class auth_plugin_fc extends auth_plugin_base {
         }
 
         // save settings
-        set_config('host',      $config->user,     'auth/fc');
+        set_config('host',      $config->host,     'auth/fc');
         set_config('fppport',   $config->fppport,  'auth/fc');
         set_config('userid',    $config->userid,   'auth/fc');
         set_config('passwd',    $config->passwd,   'auth/fc');
diff --git a/auth/fc/fcFPP.php b/auth/fc/fcFPP.php
index 57a2ef1848..7b844478e5 100644
--- a/auth/fc/fcFPP.php
+++ b/auth/fc/fcFPP.php
@@ -50,7 +50,7 @@ class fcFPP
     $conn = fsockopen($host, $port, $errno, $errstr, 5);
     if (!$conn)
     {
-        print_error('auth_fcconnfail','auth', array($errno, $errstr));
+        print_error('auth_fcconnfail','auth', '', array($errno, $errstr));
         return false;
     }
 
diff --git a/lang/en_utf8/auth.php b/lang/en_utf8/auth.php
index ba77942941..0987eb8a07 100644
--- a/lang/en_utf8/auth.php
+++ b/lang/en_utf8/auth.php
@@ -123,7 +123,7 @@ $string['auth_fchost'] = 'The FirstClass server address. Use the IP number or DN
 $string['auth_fcpasswd'] = 'Password for the account above.';
 $string['auth_fctitle'] = 'FirstClass server';
 $string['auth_fcuserid'] = 'Userid for FirstClass account with privilege \'Subadministrator\' set.';
-$string['auth_fchost_key'] = 'Host:';
+$string['auth_fchost_key'] = 'Host';
 $string['auth_fcfppport_key'] = 'Port';
 $string['auth_fcuserid_key'] = 'User ID';
 $string['auth_fcpasswd_key'] = 'Password';
-- 
2.39.5