From e582b65e30d10f304588cb28103338e8b3e073f1 Mon Sep 17 00:00:00 2001
From: paca70 <paca70>
Date: Fri, 14 Mar 2003 21:34:39 +0000
Subject: [PATCH] Fixed logic error. Now also first time users can be course
 creators.

---
 lib/moodlelib.php | 49 +++++++++++++++++++++++------------------------
 1 file changed, 24 insertions(+), 25 deletions(-)

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index abc6e347d8..3702451a82 100644
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -538,37 +538,36 @@ function authenticate_user_login($username, $password) {
 
     if (auth_user_login($username, $password)) {  // Successful authentication
         if ($user = get_user_info_from_db("username", $username)) {
-
-            if (function_exists('auth_iscreator')) {    // Check if the user is a creator
-                if (auth_iscreator($username)) {
-                    if (! record_exists("user_coursecreators", "userid", $user->id)) {
-                        $cdata['userid']=$user->id;
-                        $creator = insert_record("user_coursecreators",$cdata);
-                        if (! $creator) {
-                            error("Cannot add user to course creators.");
-                        }
-                    }
-                } else {
-                    if ( record_exists("user_coursecreators", "userid", $user->id)) {
-                        $creator = delete_record("user_coursecreators", "userid", $user->id);
-                        if (! $creator) {
-                            error("Cannot remove user from course creators.");
-                        }
-                    }
-                }
-            }
-
             if ($md5password <> $user->password) {   // Update local copy of password for reference
                 set_field("user", "password", $md5password, "username", $username);
             }
-            return $user;
-
         } else {
-            return create_user_record($username, $password);
+            $user = create_user_record($username, $password);
         }
-    }
 
-    return false;
+        if (function_exists('auth_iscreator')) {    // Check if the user is a creator
+            if (auth_iscreator($username)) {
+                 if (! record_exists("user_coursecreators", "userid", $user->id)) {
+                      $cdata['userid']=$user->id;
+                      $creator = insert_record("user_coursecreators",$cdata);
+                      if (! $creator) {
+                          error("Cannot add user to course creators.");
+                      }
+                  }
+            } else {
+                 if ( record_exists("user_coursecreators", "userid", $user->id)) {
+                      $creator = delete_record("user_coursecreators", "userid", $user->id);
+                      if (! $creator) {
+                          error("Cannot remove user from course creators.");
+                      }
+                 }
+            }
+         }
+         
+        return $user;
+    } else {
+        return false;
+    }
 }
 
 
-- 
2.39.5