From e5a3a5176d698e28ce1e8a7aaa154ed3e6824352 Mon Sep 17 00:00:00 2001
From: tjhunt <tjhunt>
Date: Mon, 29 Oct 2007 16:58:32 +0000
Subject: [PATCH] MDL-11952 - In the course admin block, if the user has
 moodle/question:managecategory, but no other capabilites, the questions link
 should go to the manage categories page. Merged from MOODLE_19_STABLE.

---
 blocks/admin/block_admin.php | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/blocks/admin/block_admin.php b/blocks/admin/block_admin.php
index 0d8a59f0db..bd963d86e9 100644
--- a/blocks/admin/block_admin.php
+++ b/blocks/admin/block_admin.php
@@ -139,6 +139,7 @@ class block_admin extends block_list {
 
     /// Manage questions
         if ($course->id!==SITEID){
+            $questionlink = '';
             $questioncaps = array(
                                     'moodle/question:add',
                                     'moodle/question:editmine',
@@ -147,15 +148,18 @@ class block_admin extends block_list {
                                     'moodle/question:viewall',
                                     'moodle/question:movemine',
                                     'moodle/question:moveall');
-            $questionpermission = false;
             foreach ($questioncaps as $questioncap){
                 if (has_capability($questioncap, $context)){
-                    $questionpermission = true;
+                    $questionlink = 'edit.php';
                     break;
                 }
             }
-            if ($questionpermission) {
-                $this->content->items[]='<a href="'.$CFG->wwwroot.'/question/edit.php?courseid='.$this->instance->pageid.'">'.get_string('questions', 'quiz').'</a>';
+            if (!$questionlink && has_capability('moodle/question:managecategory', $context)) {
+               $questionlink = 'category.php';
+            }
+            if ($questionlink) {
+                $this->content->items[]='<a href="'.$CFG->wwwroot.'/question/'.$questionlink.
+                        '?courseid='.$this->instance->pageid.'">'.get_string('questions', 'quiz').'</a>';
                 $this->content->icons[]='<img src="'.$CFG->pixpath.'/i/questions.gif" class="icon" alt="" />';
             }
         }
-- 
2.39.5