From e9a0ee701dbe01ea9a66cf5b46a768f1dddcb22c Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Sat, 28 Mar 2009 15:51:42 +0000
Subject: [PATCH] MDL-18727 param types ARE required

---
 grade/report/visual/data.php            | 8 ++++----
 grade/report/visual/index.php           | 6 +++---
 grade/report/visual/preferences.php     | 2 +-
 grade/report/visual/print.php           | 2 +-
 grade/report/visual/visual_settings.php | 6 +++---
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/grade/report/visual/data.php b/grade/report/visual/data.php
index e460f57241..ecf0a50349 100644
--- a/grade/report/visual/data.php
+++ b/grade/report/visual/data.php
@@ -26,7 +26,7 @@
  * Page to be read in by the flex application.
  * Outputs data for a visulasation in tab format.
  */
- 
+
 /// Get a session id from the URI request and make a cookie
 /// for it temparaly. This is needed as the flex application will
 /// not have the users oringal cookie and only the session information
@@ -43,12 +43,12 @@ require_once $CFG->libdir.'/gradelib.php';
 require_once $CFG->dirroot.'/grade/lib.php';
 require_once $CFG->dirroot.'/grade/report/visual/lib.php';
 
-$courseid = required_param('id');
-$visid = optional_param('visid');
+$courseid = required_param('id', PARAM_INT);
+$visid = optional_param('visid', '', PARAM_ACTION);
 
 /// basic access checks
 if (!$course = $DB->get_record('course', array('id' => $courseid))) {
-        print_error('nocourseid');
+    print_error('nocourseid');
 }
 require_login($course);
 $context = get_context_instance(CONTEXT_COURSE, $course->id);
diff --git a/grade/report/visual/index.php b/grade/report/visual/index.php
index 5d35831348..0ff4f4485c 100644
--- a/grade/report/visual/index.php
+++ b/grade/report/visual/index.php
@@ -31,12 +31,12 @@ require_once $CFG->libdir.'/gradelib.php';
 require_once $CFG->dirroot.'/grade/lib.php';
 require_once $CFG->dirroot.'/grade/report/visual/lib.php';
 
-$courseid = required_param('id');
-$visid = optional_param('visid');
+$courseid = required_param('id', PARAM_INT);
+$visid    = optional_param('visid', '', PARAM_ACTION);
 
 /// basic access checks
 if (!$course = $DB->get_record('course', array('id' => $courseid))) {
-        print_error('nocourseid');
+    print_error('nocourseid');
 }
 require_login($course);
 $context = get_context_instance(CONTEXT_COURSE, $course->id);
diff --git a/grade/report/visual/preferences.php b/grade/report/visual/preferences.php
index 30ff069182..187d2e315b 100755
--- a/grade/report/visual/preferences.php
+++ b/grade/report/visual/preferences.php
@@ -37,7 +37,7 @@ $courseid = required_param('id', PARAM_INT);
 
 /// Make sure they can even access this course
 if (!$course = $DB->get_record('course', array('id' => $courseid))) {
-        print_error('nocourseid');
+    print_error('nocourseid');
 }
 
 require_login($course);
diff --git a/grade/report/visual/print.php b/grade/report/visual/print.php
index e585ab41b3..860aabc7d5 100644
--- a/grade/report/visual/print.php
+++ b/grade/report/visual/print.php
@@ -32,7 +32,7 @@ require_once $CFG->dirroot.'/grade/lib.php';
 require_once $CFG->dirroot.'/grade/report/visual/lib.php';
 
 $courseid = required_param('id', PARAM_INT);
-$visid = optional_param('visid');
+$visid    = optional_param('visid', '', PARAM_ACTION);
 
 /// basic access checks
 if (!$course = $DB->get_record('course', array('id' => $courseid))) {
diff --git a/grade/report/visual/visual_settings.php b/grade/report/visual/visual_settings.php
index bf6fbffac1..d3db8f2139 100644
--- a/grade/report/visual/visual_settings.php
+++ b/grade/report/visual/visual_settings.php
@@ -43,12 +43,12 @@ require_once '../../../config.php';
 require_once $CFG->dirroot.'/grade/report/visual/lib.php';
 require_once $CFG->libdir.'/phpxml/xml.php';
 
-$visname = required_param('visid');
-$courseid = required_param('id');
+$visname  = required_param('visid', PARAM_ACTION);
+$courseid = required_param('id', PARAM_INT);
 
 /// basic access checks
 if (!$course = $DB->get_record('course', array('id' => $courseid))) {
-        print_error('nocourseid');
+    print_error('nocourseid');
 }
 require_login($course);
 $context = get_context_instance(CONTEXT_COURSE, $course->id);
-- 
2.39.5