From eb099f327b3145d95e93f1be59e2b72a03aef866 Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Sun, 22 Jun 2008 12:35:15 +0000
Subject: [PATCH] MDL-14956 removed some tests from create table method - no
 need to check if something exists in table if table itself does not exist yet

---
 lib/ddl/sql_generator.php | 46 ++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 25 deletions(-)

diff --git a/lib/ddl/sql_generator.php b/lib/ddl/sql_generator.php
index 3608f57db5..4552e2d06b 100644
--- a/lib/ddl/sql_generator.php
+++ b/lib/ddl/sql_generator.php
@@ -240,7 +240,7 @@ abstract class sql_generator {
      * @param boolean to specify if the name must be quoted (if reserved word, only!)
      * @return string the correct name of the table
      */
-    public function getTableName($xmldb_table, $quoted=true) {
+    public function getTableName(xmldb_table $xmldb_table, $quoted=true) {
     /// Get the name
         $tablename = $this->prefix.$xmldb_table->getName();
 
@@ -314,11 +314,9 @@ abstract class sql_generator {
     /// Add the indexes (each one, one statement)
         if ($xmldb_indexes = $xmldb_table->getIndexes()) {
             foreach ($xmldb_indexes as $xmldb_index) {
-            ///Only process all this if the index doesn't exist in DB
-                if (!$this->mdb->get_manager()->index_exists($xmldb_table, $xmldb_index)) {
-                    if ($indextext = $this->getCreateIndexSQL($xmldb_table, $xmldb_index)) {
-                        $results = array_merge($results, $indextext);
-                    }
+            ///tables do not exist yet, which means indexed can not exist yet
+                if ($indextext = $this->getCreateIndexSQL($xmldb_table, $xmldb_index)) {
+                    $results = array_merge($results, $indextext);
                 }
             }
         }
@@ -332,25 +330,23 @@ abstract class sql_generator {
                 /// Create the interim index
                     $index = new xmldb_index('anyname');
                     $index->setFields($xmldb_key->getFields());
-                ///Only process all this if the index doesn't exist in DB
-                    if (!$this->mdb->get_manager()->index_exists($xmldb_table, $index)) {
-                        $createindex = false; //By default
-                        switch ($xmldb_key->getType()) {
-                            case XMLDB_KEY_UNIQUE:
-                            case XMLDB_KEY_FOREIGN_UNIQUE:
-                                $index->setUnique(true);
-                                $createindex = true;
-                                break;
-                            case XMLDB_KEY_FOREIGN:
-                                $index->setUnique(false);
-                                $createindex = true;
-                                break;
-                        }
-                        if ($createindex) {
-                            if ($indextext = $this->getCreateIndexSQL($xmldb_table, $index)) {
-                            /// Add the INDEX to the array
-                                $results = array_merge($results, $indextext);
-                            }
+                ///tables do not exist yet, which means indexed can not exist yet
+                    $createindex = false; //By default
+                    switch ($xmldb_key->getType()) {
+                        case XMLDB_KEY_UNIQUE:
+                        case XMLDB_KEY_FOREIGN_UNIQUE:
+                            $index->setUnique(true);
+                            $createindex = true;
+                            break;
+                        case XMLDB_KEY_FOREIGN:
+                            $index->setUnique(false);
+                            $createindex = true;
+                            break;
+                    }
+                    if ($createindex) {
+                        if ($indextext = $this->getCreateIndexSQL($xmldb_table, $index)) {
+                        /// Add the INDEX to the array
+                            $results = array_merge($results, $indextext);
                         }
                     }
                 }
-- 
2.39.5